diff options
| author | Jeff King <peff@peff.net> | 2014-04-01 03:43:06 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-04-01 14:40:05 -0700 |
| commit | f80d1f95f0adf9909f42eb9e74546963daa4b0c1 (patch) | |
| tree | 075c755aec4819bc9a36adeb4174c229beaa7eb7 | |
| parent | 6654754779d2a90af91a9c6b93d7e4e7ee16cfab (diff) | |
| download | git-jk/commit-dates-parsing-fix.tar.gz | |
t4212: loosen far-in-future test for AIXjk/commit-dates-parsing-fix
One of the tests in t4212 checks our behavior when we feed
gmtime a date so far in the future that it gives up and
returns NULL. Some implementations, like AIX, may actually
just provide us a bogus result instead.
It's not worth it for us to come up with heuristics that
guess whether the return value is sensible or not. On good
platforms where gmtime reports the problem to us with NULL,
we will print the epoch value. On bad platforms, we will
print garbage. But our test should be written for the
lowest common denominator so that it passes everywhere.
Reported-by: Charles Bailey <cbailey32@bloomberg.net>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t4212-log-corrupt.sh | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/t/t4212-log-corrupt.sh b/t/t4212-log-corrupt.sh index 85c6df4ec9..1863e7163c 100755 --- a/t/t4212-log-corrupt.sh +++ b/t/t4212-log-corrupt.sh @@ -77,11 +77,9 @@ test_expect_success 'date parser recognizes time_t overflow' ' ' # date is within 2^63-1, but enough to choke glibc's gmtime -test_expect_success 'absurdly far-in-future dates produce sentinel' ' +test_expect_success 'absurdly far-in-future date' ' commit=$(munge_author_date HEAD 999999999999999999) && - echo "Thu Jan 1 00:00:00 1970 +0000" >expect && - git log -1 --format=%ad $commit >actual && - test_cmp expect actual + git log -1 --format=%ad $commit ' test_done |