diff options
| author | Ramsay Jones <ramsay@ramsayjones.plus.com> | 2017-04-30 18:29:30 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-05-01 11:03:46 +0900 |
| commit | 7f1b225153c9e75b805a262feb6796e3bf23dc3d (patch) | |
| tree | 66484aae31863d10d362c69b5fc88c94b437f4fd | |
| parent | cf9e55f49438d07dd554c5ade92f1c266363af36 (diff) | |
| download | git-bw/submodule-with-bs-path.tar.gz | |
t7400: add !CYGWIN prerequisite to 'add with \\ in path'bw/submodule-with-bs-path
Commit cf9e55f494 ("submodule: prevent backslash expantion in submodule
names", 07-04-2017) added a test which creates a git repository with
some backslash characters in the name. On windows, where the backslash
character is a directory separator, it is not possible to create a
repository with the name 'sub\with\backslash'. (The NTFS filesystem would
probably allow it, but the win32 api does not). The MinGW and Git for
Windows versions of git actually create a repository called 'backslash'
in the sub-directory 'sub/with'.
On cygwin, however, due to the slightly schizophrenic treatment of the
backslash character by cygwin-git, this test fails at the 'git init'
stage. The git-init command does not recognise the directory separators
in the input path (eg. is_dir_sep('\\') is false), so it does not
attempt to create the leading directories 'sub/with'. (The call to
mkdir('sub\\with\\backslash') actually does recognise the directory
separators, but fails because the 'sub/with' directory doesn't exist).
In order to suppress the test failure (for now), add the !CYGWIN test
prerequisite.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t7400-submodule-basic.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh index c2706fe472..d0357f1d8a 100755 --- a/t/t7400-submodule-basic.sh +++ b/t/t7400-submodule-basic.sh @@ -273,7 +273,7 @@ test_expect_success 'submodule add with ./, /.. and // in path' ' test_cmp empty untracked ' -test_expect_success 'submodule add with \\ in path' ' +test_expect_success !CYGWIN 'submodule add with \\ in path' ' test_when_finished "rm -rf parent sub\\with\\backslash" && # Initialize a repo with a backslash in its name |