summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2014-08-17 03:35:53 -0400
committerJunio C Hamano <gitster@pobox.com>2014-08-21 10:53:55 -0700
commit8837eb47f27665450c898affc39816c48edacd80 (patch)
tree43640c201b13a4d2d96aa11994d43d91e37cf8fb
parentfaa3807cfe95bace6eaa9e8775520fab713c27d0 (diff)
downloadgit-br/http-init-fix.tar.gz
http: style fixes for curl_multi_init error checkbr/http-init-fix
Unless there is a good reason, we should use die() rather than fprintf/exit. We can also shorten the message to match other curl init failures (and match our usual lowercase no-full-stop style). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--http.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/http.c b/http.c
index 0276aa9426..d33b122cd1 100644
--- a/http.c
+++ b/http.c
@@ -421,10 +421,8 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
}
curlm = curl_multi_init();
- if (curlm == NULL) {
- fprintf(stderr, "Error creating curl multi handle.\n");
- exit(1);
- }
+ if (!curlm)
+ die("curl_multi_init failed");
#endif
if (getenv("GIT_SSL_NO_VERIFY"))