summaryrefslogtreecommitdiff
path: root/log-replayer
diff options
context:
space:
mode:
authorMarco Residori <marco_residori@mentor.com>2015-09-27 09:20:34 +0200
committerMarco Residori <marco_residori@mentor.com>2015-09-27 09:20:34 +0200
commit4b07762bc58fc8114e02dbe0d8ad96b355b44b20 (patch)
tree184c4fa9fa92f368342893839078519c1e9bf34c /log-replayer
parentd7a462c970886b063db8d5f04d91931f8b36543b (diff)
downloadpositioning-4b07762bc58fc8114e02dbe0d8ad96b355b44b20.tar.gz
Fix defects identified by Coverity Scan
Diffstat (limited to 'log-replayer')
-rw-r--r--log-replayer/src/log-replayer.c14
-rw-r--r--log-replayer/test/test-log-replayer.c2
2 files changed, 10 insertions, 6 deletions
diff --git a/log-replayer/src/log-replayer.c b/log-replayer/src/log-replayer.c
index b43f085..c5afd51 100644
--- a/log-replayer/src/log-replayer.c
+++ b/log-replayer/src/log-replayer.c
@@ -35,7 +35,7 @@
#define PORT2 9931 //port used for sensor data
#define PORT3 9932 //port used for vehicle data
#define IPADDR_DEFAULT "127.0.0.1"
-#define MAXDELTA 1000000 //max value to avoid overflow
+#define MAXDELTA 1000 //max value to avoid overflow
DLT_DECLARE_CONTEXT(gContext);
@@ -51,7 +51,7 @@ bool getStrToSend(FILE* file, char* line, int dim)
{
static long unsigned int lastTimestamp = 0;
long unsigned int timestamp = 0;
- long unsigned int delta = 0;
+ long signed int delta = 0;
if(dim <= 0)
{
@@ -108,11 +108,15 @@ bool getStrToSend(FILE* file, char* line, int dim)
if(delta > MAXDELTA)
{
- LOG_WARNING(gContext,"timestamp - lastTimestamp too big at %ld. ignoring line to avoid overflow", timestamp);
- return true;
+ LOG_WARNING(gContext,"delta time too big at %ld. delta time set to %d to avoid overflow", timestamp, MAXDELTA);
+ delta = MAXDELTA;
}
- usleep(delta*1000); // TODO time drift issues
+ if(usleep(delta*1000) != 0) // TODO time drift issues
+ {
+ LOG_WARNING(gContext,"uslee failed");
+ return true;
+ }
return true;
}
diff --git a/log-replayer/test/test-log-replayer.c b/log-replayer/test/test-log-replayer.c
index 5d9c24a..7867661 100644
--- a/log-replayer/test/test-log-replayer.c
+++ b/log-replayer/test/test-log-replayer.c
@@ -73,7 +73,7 @@ int main(int argc, char* argv[])
{
readBytes = recvfrom(s, buf, BUFLEN, 0, (struct sockaddr *) &si_other, &slen);
- if(readBytes == -1)
+ if(readBytes < 0)
{
LOG_ERROR_MSG(gContext,"recvfrom() failed!");
return EXIT_FAILURE;