diff options
author | Jakub Jelinek <jakub@redhat.com> | 2022-01-10 15:38:47 +0100 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2022-01-10 15:38:47 +0100 |
commit | a8d3c98746098e2784be7144c1ccc9fcc34a0888 (patch) | |
tree | aa4b7c7d9031a5d49656f13d42d122c0c9b5f941 /libstdc++-v3/testsuite/22_locale/time_get/get_year/char | |
parent | 68c2e9e9234cb301e9e81792cad233a41e797792 (diff) | |
download | gcc-a8d3c98746098e2784be7144c1ccc9fcc34a0888.tar.gz |
libstdc++: Add %j, %U, %w, %W time_get support, fix %y, %Y, %C, %p [PR77760]
glibc strptime passes around some state, what fields in struct tm have been
set and what needs to be finalized through possibly recursive calls, and
at the end performs various finalizations, like applying %p so that it
works for both %I %p and %p %I orders, or applying century so that both
%C %y and %y %C works, or computation of missing fields from others
(e.g. from %Y and %j one can compute tm_mon, tm_mday and tm_wday,
from %Y %U %w, %Y %W %w, %Y %U %a, or %Y %W %w one can compute
tm_mon, tm_mday, tm_yday or e.g. from %Y %m %d one can compute tm_wday
and tm_yday.
As the finalization is quite large and doesn't need to be a template
(doesn't depend on any iterators or char types), I've put it into libstdc++,
and left some padding in the state struct, so that perhaps in the future we
can track some more state without changing ABI.
Unfortunately, there is an ugly problem that the standard mandates that
get method calls the do_get virtual method and I don't see how we can
cary on any state in between those calls (even if we did an ABI change
for the facets, the methods are const, so that I think multiple threads
could use the same time_get objects and we couldn't store state in there).
There is a hack for that for GCC (seems to work with ICC too, doesn't work
with clang++) if the do_get method isn't overriden we can pass the state
around.
For both do_get_year and per IRC discussions also for %y, the behavior is
if 1-2 digits are parsed, the year is treated according to POSIX 2008 %y
rules (0-68 is 2000-2068, 69-99 is 1969-1999), if 3-4 digits are parsed,
it is treated as %Y.
2022-01-10 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/77760
* include/bits/locale_facets_nonio.h (__time_get_state): New struct.
(time_get::_M_extract_via_format): Declare new method with
__time_get_state& as an extra argument.
* include/bits/locale_facets_nonio.tcc (_M_extract_via_format): Add
__state argument, set various fields in it while parsing. Handle %j,
%U, %w and %W, fix up handling of %y, %Y and %C, don't adjust tm_hour
for %p immediately. Add a wrapper around the method without the
__state argument for backwards compatibility.
(_M_extract_num): Remove all __len == 4 special cases.
(time_get::do_get_time, time_get::do_get_date, time_get::do_get): Zero
initialize __state, pass it to _M_extract_via_format and finalize it
at the end.
(do_get_year): For 1-2 digit parsed years, map 0-68 to 2000-2068,
69-99 to 1969-1999. For 3-4 digit parsed years use that as year.
(get): If do_get isn't overloaded from the locale_facets_nonio.tcc
version, don't call do_get but call _M_extract_via_format instead to
pass around state.
* config/abi/pre/gnu.ver (GLIBCXX_3.4.30): Export _M_extract_via_format
with extra __time_get_state and __time_get_state::_M_finalize_state.
* src/c++98/locale_facets.cc (is_leap, day_of_the_week,
day_of_the_year): New functions in anon namespace.
(mon_yday): New var in anon namespace.
(__time_get_state::_M_finalize_state): Define.
* testsuite/22_locale/time_get/get/char/4.cc: New test.
* testsuite/22_locale/time_get/get/wchar_t/4.cc: New test.
* testsuite/22_locale/time_get/get_year/char/1.cc (test01): Parse 197
as year 197AD instead of error.
* testsuite/22_locale/time_get/get_year/char/5.cc (test01): Parse 1 as
year 2001 instead of error.
* testsuite/22_locale/time_get/get_year/char/6.cc: New test.
* testsuite/22_locale/time_get/get_year/wchar_t/1.cc (test01): Parse
197 as year 197AD instead of error.
* testsuite/22_locale/time_get/get_year/wchar_t/5.cc (test01): Parse
1 as year 2001 instead of error.
* testsuite/22_locale/time_get/get_year/wchar_t/6.cc: New test.
Diffstat (limited to 'libstdc++-v3/testsuite/22_locale/time_get/get_year/char')
3 files changed, 85 insertions, 5 deletions
diff --git a/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/1.cc b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/1.cc index c9d9896a6c0..e6f53de4a55 100644 --- a/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/1.cc +++ b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/1.cc @@ -76,8 +76,8 @@ void test01() errorstate = good; iterator_type ret03 = tim_get.get_year(is_it03, end, iss, errorstate, &time03); - VERIFY( time03.tm_year == 3 ); - VERIFY( errorstate == ios_base::failbit ); + VERIFY( time03.tm_year == 197 - 1900 ); + VERIFY( errorstate == good ); VERIFY( *ret03 == 'd' ); iss.str("71d71"); diff --git a/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/5.cc b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/5.cc index d518d96c45f..c4544479828 100644 --- a/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/5.cc +++ b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/5.cc @@ -49,12 +49,13 @@ void test01() const string str0 = "1"; tg.get_year(str0.begin(), str0.end(), iss, err, &tm0); - VERIFY( err == (failbit | eofbit) ); - VERIFY( tm0.tm_year == 0 ); + VERIFY( err == eofbit ); + VERIFY( tm0.tm_year == 2001 - 1900 ); const string str1 = "1997 "; + err = goodbit; iter_type end1 = tg.get_year(str1.begin(), str1.end(), iss, err, &tm1); - VERIFY( err == (failbit | eofbit) ); + VERIFY( err == goodbit ); VERIFY( tm1.tm_year == time_sanity.tm_year ); VERIFY( *end1 == ' ' ); } diff --git a/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/6.cc b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/6.cc new file mode 100644 index 00000000000..e50afa6aa73 --- /dev/null +++ b/libstdc++-v3/testsuite/22_locale/time_get/get_year/char/6.cc @@ -0,0 +1,79 @@ +// Copyright (C) 2001-2022 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// 22.2.5.1.1 time_get members + +#include <locale> +#include <sstream> +#include <testsuite_hooks.h> + +void test01() +{ + using namespace std; + + typedef istreambuf_iterator<char> iterator_type; + + locale loc_c = locale::classic(); + + iterator_type end; + + istringstream iss; + iss.imbue(loc_c); + const time_get<char>& tim_get = use_facet<time_get<char> >(iss.getloc()); + ios_base::iostate errorstate = ios_base::goodbit; + + iss.str("69"); + iterator_type is_it01(iss); + tm time01; + tim_get.get_year(is_it01, end, iss, errorstate, &time01); + VERIFY( time01.tm_year == 1969 - 1900 ); + VERIFY( errorstate == ios_base::eofbit ); + + iss.str("68 "); + iterator_type is_it02(iss); + tm time02; + errorstate = ios_base::goodbit; + iterator_type ret02 = tim_get.get_year(is_it02, end, iss, errorstate, + &time02); + VERIFY( time02.tm_year == 2068 - 1900 ); + VERIFY( errorstate == ios_base::goodbit ); + VERIFY( *ret02 == ' ' ); + + iss.str("0069"); + iterator_type is_it03(iss); + tm time03; + errorstate = ios_base::goodbit; + iterator_type ret03 = tim_get.get_year(is_it03, end, iss, errorstate, + &time03); + VERIFY( time03.tm_year == 69 - 1900 ); + VERIFY( errorstate == ios_base::eofbit ); + + iss.str("0068"); + iterator_type is_it04(iss); + tm time04; + errorstate = ios_base::goodbit; + iterator_type ret04 = tim_get.get_year(is_it04, end, iss, errorstate, + &time04); + VERIFY( time04.tm_year == 68 - 1900 ); + VERIFY( errorstate == ios_base::eofbit ); +} + +int main() +{ + test01(); + return 0; +} |