diff options
author | Jakub Jelinek <jakub@redhat.com> | 2022-05-17 15:40:27 +0200 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2022-05-17 15:40:27 +0200 |
commit | 2c16eb3157f86ae561468c540caf8eb326106b5f (patch) | |
tree | d14eeb859d38591bdd83f3754a627ba21c4d5fae /libgomp/task.c | |
parent | 1815462a6e53465c404f8a5f6116891492d4b50b (diff) | |
download | gcc-2c16eb3157f86ae561468c540caf8eb326106b5f.tar.gz |
openmp: Add support for inoutset depend-kind
This patch adds support for inoutset depend-kind in depend
clauses. It is very similar to the in depend-kind in that
a task with a dependency with that depend-kind is dependent
on all previously created sibling tasks with matching address
unless they have the same depend-kind.
In the in depend-kind case everything is dependent except
for in -> in dependency, for inoutset everything is
dependent except for inoutset -> inoutset dependency.
mutexinoutset is also similar (everything is dependent except
for mutexinoutset -> mutexinoutset dependency), but there is
also the additional restriction that only one task with
mutexinoutset for each address can be scheduled at once (i.e.
mutual exclusitivty). For now we support mutexinoutset
the same as inout/out, but the inoutset support is full.
In order not to bump the ABI for dependencies each time
(we've bumped it already once, the old ABI supports only
inout/out and in depend-kind, the new ABI supports
inout/out, mutexinoutset, in and depobj), this patch arranges
for inoutset to be at least for the time being always handled
as if it was specified through depobj even when it is not.
So it uses the new ABI for that and inoutset are represented
like depobj - pointer to a pair of pointers where the first one
will be the actual address of the object mentioned in depend
clause and second pointer will be (void *) GOMP_DEPEND_INOUTSET.
2022-05-17 Jakub Jelinek <jakub@redhat.com>
gcc/
* tree-core.h (enum omp_clause_depend_kind): Add
OMP_CLAUSE_DEPEND_INOUTSET.
* tree-pretty-print.cc (dump_omp_clause): Handle
OMP_CLAUSE_DEPEND_INOUTSET.
* gimplify.cc (gimplify_omp_depend): Likewise.
* omp-low.cc (lower_depend_clauses): Likewise.
gcc/c-family/
* c-omp.cc (c_finish_omp_depobj): Handle
OMP_CLAUSE_DEPEND_INOUTSET.
gcc/c/
* c-parser.cc (c_parser_omp_clause_depend): Parse
inoutset depend-kind.
(c_parser_omp_depobj): Likewise.
gcc/cp/
* parser.cc (cp_parser_omp_clause_depend): Parse
inoutset depend-kind.
(cp_parser_omp_depobj): Likewise.
* cxx-pretty-print.cc (cxx_pretty_printer::statement): Handle
OMP_CLAUSE_DEPEND_INOUTSET.
gcc/testsuite/
* c-c++-common/gomp/all-memory-1.c (boo): Add test with
inoutset depend-kind.
* c-c++-common/gomp/all-memory-2.c (boo): Likewise.
* c-c++-common/gomp/depobj-1.c (f1): Likewise.
(f2): Adjusted expected diagnostics.
* g++.dg/gomp/depobj-1.C (f4): Adjust expected diagnostics.
include/
* gomp-constants.h (GOMP_DEPEND_INOUTSET): Define.
libgomp/
* libgomp.h (struct gomp_task_depend_entry): Change is_in type
from bool to unsigned char.
* task.c (gomp_task_handle_depend): Handle GOMP_DEPEND_INOUTSET.
Ignore dependencies where
task->depend[i].is_in && task->depend[i].is_in == ent->is_in
rather than just task->depend[i].is_in && ent->is_in. Remember
whether GOMP_DEPEND_IN loop is needed and guard the loop with that
conditional.
(gomp_task_maybe_wait_for_dependencies): Handle GOMP_DEPEND_INOUTSET.
Ignore dependencies where elem.is_in && elem.is_in == ent->is_in
rather than just elem.is_in && ent->is_in.
* testsuite/libgomp.c-c++-common/depend-1.c (test): Add task with
inoutset depend-kind.
* testsuite/libgomp.c-c++-common/depend-2.c (test): Likewise.
* testsuite/libgomp.c-c++-common/depend-3.c (test): Likewise.
* testsuite/libgomp.c-c++-common/depend-inoutset-1.c: New test.
Diffstat (limited to 'libgomp/task.c')
-rw-r--r-- | libgomp/task.c | 33 |
1 files changed, 22 insertions, 11 deletions
diff --git a/libgomp/task.c b/libgomp/task.c index db4a6f71fb7..e9a28bf71cb 100644 --- a/libgomp/task.c +++ b/libgomp/task.c @@ -197,6 +197,7 @@ gomp_task_handle_depend (struct gomp_task *task, struct gomp_task *parent, /* ndepend - nout - nmutexinoutset - nin is # of depobjs */ size_t normal = nout + nmutexinoutset + nin; size_t n = 0; + bool has_in = false; for (i = normal; i < ndepend; i++) { void **d = (void **) (uintptr_t) depend[5 + i]; @@ -209,6 +210,8 @@ gomp_task_handle_depend (struct gomp_task *task, struct gomp_task *parent, case GOMP_DEPEND_MUTEXINOUTSET: break; case GOMP_DEPEND_IN: + case GOMP_DEPEND_INOUTSET: + has_in = true; continue; default: gomp_fatal ("unknown omp_depend_t dependence type %d", @@ -222,14 +225,17 @@ gomp_task_handle_depend (struct gomp_task *task, struct gomp_task *parent, task->depend[n].addr = depend[5 + i]; task->depend[n++].is_in = i >= nout + nmutexinoutset; } - for (i = normal; i < ndepend; i++) - { - void **d = (void **) (uintptr_t) depend[5 + i]; - if ((uintptr_t) d[1] != GOMP_DEPEND_IN) - continue; - task->depend[n].addr = d[0]; - task->depend[n++].is_in = 1; - } + if (has_in) + for (i = normal; i < ndepend; i++) + { + void **d = (void **) (uintptr_t) depend[5 + i]; + if ((uintptr_t) d[1] != GOMP_DEPEND_IN + && (uintptr_t) d[1] != GOMP_DEPEND_INOUTSET) + continue; + task->depend[n].addr = d[0]; + task->depend[n++].is_in + = 1 + ((uintptr_t) d[1] == GOMP_DEPEND_INOUTSET); + } } task->num_dependees = 0; if (__builtin_expect (parent->depend_all_memory && ndepend, false)) @@ -381,8 +387,10 @@ gomp_task_handle_depend (struct gomp_task *task, struct gomp_task *parent, last = ent; - /* depend(in:...) doesn't depend on earlier depend(in:...). */ - if (task->depend[i].is_in && ent->is_in) + /* depend(in:...) doesn't depend on earlier depend(in:...). + Similarly depend(inoutset:...) doesn't depend on earlier + depend(inoutset:...). */ + if (task->depend[i].is_in && task->depend[i].is_in == ent->is_in) continue; if (!ent->is_in) @@ -1890,6 +1898,9 @@ gomp_task_maybe_wait_for_dependencies (void **depend) case GOMP_DEPEND_MUTEXINOUTSET: elem.is_in = 0; break; + case GOMP_DEPEND_INOUTSET: + elem.is_in = 2; + break; default: gomp_fatal ("unknown omp_depend_t dependence type %d", (int) (uintptr_t) d[1]); @@ -1928,7 +1939,7 @@ gomp_task_maybe_wait_for_dependencies (void **depend) } ent = htab_find (task->depend_hash, &elem); for (; ent; ent = ent->next) - if (elem.is_in && ent->is_in) + if (elem.is_in && elem.is_in == ent->is_in) continue; else { |