diff options
| author | Aarya Chaumal <aarya.chaumal@gmail.com> | 2023-05-02 23:06:56 +0530 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2023-05-06 13:20:32 +0000 |
| commit | 3d5c9a5cea13e4e9acf73a9dbd5b549a3774b0a4 (patch) | |
| tree | c94fe814c10c80abd81208fdbba89594a9369935 | |
| parent | 70a38170b9e592c70f12df1a62723b372f5b3312 (diff) | |
| download | flashrom-git-3d5c9a5cea13e4e9acf73a9dbd5b549a3774b0a4.tar.gz | |
erasure_layout.c: Fix incorrect return value in erase_write
On failure of erasefn in erase_write it didn't set the error value in
ret which caused send success status as return value.
Change-Id: Ia3bd5fd250dcd0a03f0281c478b9bacb71872f31
Signed-off-by: Aarya Chaumal <aarya.chaumal@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/74882
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
| -rw-r--r-- | erasure_layout.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/erasure_layout.c b/erasure_layout.c index a802ae48..108fea4c 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -328,9 +328,12 @@ int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff addr, addr + len - 1); free(region.name); - if (erasefn(flashctx, addr, len)) + if (erasefn(flashctx, addr, len)) { + ret = -1; goto _end; + } if (check_erased_range(flashctx, addr, len)) { + ret = - 1; msg_cerr("ERASE FAILED!\n"); goto _end; } |