summaryrefslogtreecommitdiff
path: root/src/test_libs_common
diff options
context:
space:
mode:
authorErik de Castro Lopo <erikd@mega-nerd.com>2015-08-27 08:42:23 +1000
committerErik de Castro Lopo <erikd@mega-nerd.com>2015-08-27 09:34:43 +1000
commit25d387377a0dcb5b2fd2aafab09bdd9c8b1e3ac7 (patch)
treec546b48a38492dac8098ac89389d12c199fdec90 /src/test_libs_common
parenta14581642c9e7dcee15d05bde9fd0a6a47350dcc (diff)
downloadflac-25d387377a0dcb5b2fd2aafab09bdd9c8b1e3ac7.tar.gz
tests: Fix undefined behaviour
Undefined behaviour in the test support code.
Diffstat (limited to 'src/test_libs_common')
-rw-r--r--src/test_libs_common/metadata_utils.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test_libs_common/metadata_utils.c b/src/test_libs_common/metadata_utils.c
index cef32220..11491f8b 100644
--- a/src/test_libs_common/metadata_utils.c
+++ b/src/test_libs_common/metadata_utils.c
@@ -338,7 +338,7 @@ FLAC__bool mutils__compare_block_data_picture(const FLAC__StreamMetadata_Picture
printf("FAILED, data_length mismatch, expected %u, got %u\n", block->data_length, blockcopy->data_length);
return false;
}
- if(memcmp(blockcopy->data, block->data, block->data_length)) {
+ if(block->data_length > 0 && memcmp(blockcopy->data, block->data, block->data_length)) {
printf("FAILED, data mismatch\n");
return false;
}