diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2014-11-10 23:07:50 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2014-11-10 23:09:39 +0100 |
| commit | 5dcb99033df16eccc4dbbc4a099ad64457f9f090 (patch) | |
| tree | 28b828ed0e8995c4608d714a148694ad8cb39980 | |
| parent | 8c28a39c2c38fd9d13dc5247fca7bca8b3f2fcad (diff) | |
| download | ffmpeg-5dcb99033df16eccc4dbbc4a099ad64457f9f090.tar.gz | |
avcodec/wmaprodec: Fix integer overflow in sfb_offsets initialization
Fixes out of array read
Fixes: asan_heap-oob_2aec5b0_1828_classical_22_16_2_16000_v3c_0_exclusive_0_29.wma
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/wmaprodec.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index f45e1fcdbc..56d6d32831 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -422,6 +422,9 @@ static av_cold int decode_init(AVCodecContext *avctx) offset &= ~3; if (offset > s->sfb_offsets[i][band - 1]) s->sfb_offsets[i][band++] = offset; + + if (offset >= subframe_len) + break; } s->sfb_offsets[i][band - 1] = subframe_len; s->num_sfb[i] = band - 1; |