diff options
| author | Michael Jennings <mej@kainx.org> | 2008-05-14 19:49:22 +0000 |
|---|---|---|
| committer | Michael Jennings <mej@kainx.org> | 2008-05-14 19:49:22 +0000 |
| commit | 3df02b2205c960d4c18293a64fccb8b603480c39 (patch) | |
| tree | aa255fc43c4b0576cef74132df31733833648539 /ChangeLog | |
| parent | b9f3a99c5690cfd26f986cc1940275ad29714fb6 (diff) | |
| download | eterm-3df02b2205c960d4c18293a64fccb8b603480c39.tar.gz | |
Wed May 14 12:42:51 2008 Michael Jennings (mej)
Patch from Kim Woelders <kim@woelders.dk>:
There is a race problem with Eterm during startup related to the
shell LINES/COLUMNS env vars.
If the WM changes the window size (e.g. due to saved settings)
before mapping the window, sometimes the shell will set LINES and
COLUMNS according to the old/incorrect size and sometimes to the
new/correct size, depending on wheter the call to tt_winsize() at
command.c line 2322 (by the shell child process) or the
tt_resize() (by the Eterm process) due to the ConfigureNotify
caused by the resize (or WM ICCCM ConfigureNotify) operation
happens first.
The call in question was added by Azundris for Escreen. So far
Escreen seems to be behaving properly with this patch applied, but all
my Eterm windows (Escreen and otherwise) are pre-sized with -g anyway.
So I'm going to keep my eye on it for awhile. In case of trouble,
change the "#if 0" to "#ifdef ESCREEN" to revert to previous behavior
when in Escreen mode. Normal operation should not require the call in
question.
----------------------------------------------------------------------
SVN revision: 34568
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 24 |
1 files changed, 24 insertions, 0 deletions
@@ -5531,3 +5531,27 @@ Tue Jul 3 20:48:46 2007 Michael Jennings (mej) Remove some cruft from kEsetroot. ---------------------------------------------------------------------- +Wed May 14 12:42:51 2008 Michael Jennings (mej) + +Patch from Kim Woelders <kim@woelders.dk>: + + There is a race problem with Eterm during startup related to the + shell LINES/COLUMNS env vars. + + If the WM changes the window size (e.g. due to saved settings) + before mapping the window, sometimes the shell will set LINES and + COLUMNS according to the old/incorrect size and sometimes to the + new/correct size, depending on wheter the call to tt_winsize() at + command.c line 2322 (by the shell child process) or the + tt_resize() (by the Eterm process) due to the ConfigureNotify + caused by the resize (or WM ICCCM ConfigureNotify) operation + happens first. + +The call in question was added by Azundris for Escreen. So far +Escreen seems to be behaving properly with this patch applied, but all +my Eterm windows (Escreen and otherwise) are pre-sized with -g anyway. +So I'm going to keep my eye on it for awhile. In case of trouble, +change the "#if 0" to "#ifdef ESCREEN" to revert to previous behavior +when in Escreen mode. Normal operation should not require the call in +question. +---------------------------------------------------------------------- |