diff options
| author | Vibhav Pant <vibhavp@gmail.com> | 2023-03-01 15:04:34 +0530 |
|---|---|---|
| committer | Vibhav Pant <vibhavp@gmail.com> | 2023-03-06 20:28:20 +0530 |
| commit | 1e5393a57a3bbe3f9167fee59232c2e424afadf2 (patch) | |
| tree | 55eaa6af112b2ddb1978fc729643ff9ba7f1a81b /test/lisp/emacs-lisp | |
| parent | 186643ea8a8e36bf3264b36c4106793cea25c6b3 (diff) | |
| download | emacs-1e5393a57a3bbe3f9167fee59232c2e424afadf2.tar.gz | |
Don't modify interactive closures destructively (Bug#60974).
* lisp/emacs-lisp/cconv.el (cconv-convert): When form is an
interactive lambda form, don't destructively modify it, as it might be
a constant literal. Instead, create a new list with the relevant
place(s) changed.
* test/lisp/emacs-lisp/cconv-tests.el
(cconv-tests-interactive-form-modify-bug60974): New test.
Diffstat (limited to 'test/lisp/emacs-lisp')
| -rw-r--r-- | test/lisp/emacs-lisp/cconv-tests.el | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/lisp/emacs-lisp/cconv-tests.el b/test/lisp/emacs-lisp/cconv-tests.el index 349ffeb7e47..6facd3452ea 100644 --- a/test/lisp/emacs-lisp/cconv-tests.el +++ b/test/lisp/emacs-lisp/cconv-tests.el @@ -376,6 +376,18 @@ (eval '(lambda (x) :closure-dont-trim-context (+ x 1)) `((y . ,magic-string))))))) +(ert-deftest cconv-tests-interactive-form-modify-bug60974 () + (let* ((f '(function (lambda (&optional arg) + (interactive + (list (if current-prefix-arg + (prefix-numeric-value current-prefix-arg) + 'toggle))) + (ignore arg)))) + (if (cadr (nth 2 (cadr f)))) + (if2)) + (cconv-closure-convert f) + (setq if2 (cadr (nth 2 (cadr f)))) + (should (eq if if2)))) (provide 'cconv-tests) ;;; cconv-tests.el ends here |