Lisp code shouldn't use set-time-zone-rule except through setenv.

* time.el (display-time-world-list, display-time-world-display):
* time-stamp.el (time-stamp-string):
* vc/add-log.el (add-change-log-entry): Use setenv instead of
set-time-zone-rule.

* src/editfns.c (Fset_time_zone_rule): Document relationship with the
setenv function.

Fixes: debbugs:7337

1 files changed, 32 insertions, 29 deletions

diff --git a/lisp/time.el b/lisp/time.el
index b158ef64691..f8fea0c64a2 100644
--- a/lisp/time.el
+++ b/lisp/time.el
@@ -156,21 +156,24 @@ LABEL is a string to display as the label of that TIMEZONE's time."
 (defcustom display-time-world-list
   ;; Determine if zoneinfo style timezones are supported by testing that
   ;; America/New York and Europe/London return different timezones.
-  (let (gmt nyt)
-    (set-time-zone-rule "America/New_York")
-    (setq nyt (format-time-string "%z"))
-    (set-time-zone-rule "Europe/London")
-    (setq gmt (format-time-string "%z"))
-    (set-time-zone-rule nil)
+  (let ((old-tz (getenv "TZ"))
+	gmt nyt)
+    (unwind-protect
+	(progn
+	  (setenv "TZ" "America/New_York")
+	  (setq nyt (format-time-string "%z"))
+	  (setenv "TZ" "Europe/London")
+	  (setq gmt (format-time-string "%z")))
+      (setenv "TZ" old-tz))
     (if (string-equal nyt gmt)
         legacy-style-world-list
       zoneinfo-style-world-list))
   "Alist of time zones and places for `display-time-world' to display.
 Each element has the form (TIMEZONE LABEL).
-TIMEZONE should be in the format supported by `set-time-zone-rule' on
-your system.  See the documentation of `zoneinfo-style-world-list' and
-\`legacy-style-world-list' for two widely used formats.
-LABEL is a string to display as the label of that TIMEZONE's time."
+TIMEZONE should be in a format supported by your system.  See the
+documentation of `zoneinfo-style-world-list' and
+\`legacy-style-world-list' for two widely used formats.  LABEL is
+a string to display as the label of that TIMEZONE's time."
   :group 'display-time
   :type '(repeat (list string string))
   :version "23.1")
@@ -521,26 +524,26 @@ See `display-time-world'."
 (defun display-time-world-display (alist)
   "Replace current buffer text with times in various zones, based on ALIST."
   (let ((inhibit-read-only t)
-	(buffer-undo-list t))
+	(buffer-undo-list t)
+	(old-tz (getenv "TZ"))
+	(max-width 0)
+	result fmt)
     (erase-buffer)
-    (let ((max-width 0)
-	  (result ())
-	  fmt)
-      (unwind-protect
-	  (dolist (zone alist)
-	    (let* ((label (cadr zone))
-		   (width (string-width label)))
-	      (set-time-zone-rule (car zone))
-	      (push (cons label
-			  (format-time-string display-time-world-time-format))
-		    result)
-	      (when (> width max-width)
-		(setq max-width width))))
-	(set-time-zone-rule nil))
-      (setq fmt (concat "%-" (int-to-string max-width) "s %s\n"))
-      (dolist (timedata (nreverse result))
-	(insert (format fmt (car timedata) (cdr timedata)))))
-    (delete-char -1)))
+    (unwind-protect
+	(dolist (zone alist)
+	  (let* ((label (cadr zone))
+		 (width (string-width label)))
+	    (setenv "TZ" (car zone))
+	    (push (cons label
+			(format-time-string display-time-world-time-format))
+		  result)
+	    (when (> width max-width)
+	      (setq max-width width))))
+      (setenv "TZ" old-tz))
+    (setq fmt (concat "%-" (int-to-string max-width) "s %s\n"))
+    (dolist (timedata (nreverse result))
+      (insert (format fmt (car timedata) (cdr timedata)))))
+  (delete-char -1))
 
 ;;;###autoload
 (defun display-time-world ()