summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Ingebrigtsen <larsi@gnus.org>2020-09-13 16:46:11 +0200
committerLars Ingebrigtsen <larsi@gnus.org>2020-09-13 16:46:11 +0200
commitdef34a20766ea5179afd5e5ed090a2b86fcccb5e (patch)
tree5315814cc1010fa9b396fde5ff37f072522dcd8f
parentc2dea983e8016dab6e76a10d8b02ffbf894e2760 (diff)
downloademacs-def34a20766ea5179afd5e5ed090a2b86fcccb5e.tar.gz
Don't eagerly store articles in the Agent by default
* lisp/gnus/gnus-agent.el (gnus-agent-store-article): Made obsolete. * lisp/gnus/gnus-art.el (gnus-request-article-this-buffer): Don't call it. * lisp/gnus/gnus-async.el (gnus-async-article-callback): Ditto (bug#43356). This partially reverts f3b146e943cd733fb716c75048f24b73826e5f30, which in was response to what appears to be an erroneous feature-request - bug#8502. Instead this should be done instead: “If I read an article while plugged, do they get entered into the Agent?” *No*. If you want this behavior, add ‘gnus-agent-fetch-selected-article’ to ‘gnus-select-article-hook’.
-rw-r--r--lisp/gnus/gnus-agent.el1
-rw-r--r--lisp/gnus/gnus-art.el5
-rw-r--r--lisp/gnus/gnus-async.el6
3 files changed, 2 insertions, 10 deletions
diff --git a/lisp/gnus/gnus-agent.el b/lisp/gnus/gnus-agent.el
index 03e447e072a..d7388d480c3 100644
--- a/lisp/gnus/gnus-agent.el
+++ b/lisp/gnus/gnus-agent.el
@@ -3812,6 +3812,7 @@ has been fetched."
t))))
(defun gnus-agent-store-article (article group)
+ (declare (obsolete nil "28.1"))
(let* ((gnus-command-method (gnus-find-method-for-group group))
(file (gnus-agent-article-name (number-to-string article) group))
(file-name-coding-system nnmail-pathname-coding-system)
diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
index e0339cc1f32..13a85379970 100644
--- a/lisp/gnus/gnus-art.el
+++ b/lisp/gnus/gnus-art.el
@@ -7084,10 +7084,7 @@ If given a prefix, show the hidden text instead."
gnus-summary-buffer)
(when gnus-keep-backlog
(gnus-backlog-enter-article
- group article (current-buffer)))
- (when (and gnus-agent
- (gnus-agent-group-covered-p group))
- (gnus-agent-store-article article group)))
+ group article (current-buffer))))
(setq result 'article))
(methods
(setq gnus-override-method (pop methods)))
diff --git a/lisp/gnus/gnus-async.el b/lisp/gnus/gnus-async.el
index e3e81c8bbce..9bcb6c33a64 100644
--- a/lisp/gnus/gnus-async.el
+++ b/lisp/gnus/gnus-async.el
@@ -225,12 +225,6 @@ that was fetched."
(save-excursion
(save-restriction
(narrow-to-region mark (point-max))
- ;; Put the articles into the agent, if they aren't already.
- (when (and gnus-agent
- (gnus-agent-group-covered-p group))
- (save-restriction
- (narrow-to-region mark (point-max))
- (gnus-agent-store-article article group)))
;; Prefetch images for the groups that want that.
(when (fboundp 'gnus-html-prefetch-images)
(gnus-html-prefetch-images summary))