summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJackson Ray Hamilton <jackson@jacksonrayhamilton.com>2019-04-08 08:36:38 -0700
committerJackson Ray Hamilton <jackson@jacksonrayhamilton.com>2019-04-08 08:36:38 -0700
commitf046d6e9d2b74cade3712571525da3e62592eaf7 (patch)
treecc605c2f34e094186caac12d50b6555954227b12
parent58b2cdc6dbaedee8bf3b779f2ac594fd68d538a4 (diff)
downloademacs-feature/jsx.tar.gz
Permit non-ASCII identifiers in JSfeature/jsx
* lisp/progmodes/js.el (js--name-start-re): Generally allow identifiers to begin with non-ASCII letters. This is of particular importance to JSX parsing. * test/manual/indent/jsx-unclosed-2.jsx: Add test to ensure non-ASCII characters are parsed properly.
-rw-r--r--lisp/progmodes/js.el2
-rw-r--r--test/manual/indent/jsx-unclosed-2.jsx7
2 files changed, 8 insertions, 1 deletions
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index b1068bfc7b8..9185371b523 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -65,7 +65,7 @@
;;; Constants
-(defconst js--name-start-re (concat "[a-zA-Z_$]")
+(defconst js--name-start-re (concat "[[:alpha:]_$]")
"Regexp matching the start of a JavaScript identifier, without grouping.")
(defconst js--stmt-delim-chars "^;{}?:")
diff --git a/test/manual/indent/jsx-unclosed-2.jsx b/test/manual/indent/jsx-unclosed-2.jsx
index be0a605503f..fb665b96a43 100644
--- a/test/manual/indent/jsx-unclosed-2.jsx
+++ b/test/manual/indent/jsx-unclosed-2.jsx
@@ -56,3 +56,10 @@ while (await foo > bar) void 0
/ >
< / div>
< / div >
+
+// Non-ASCII identifiers are acceptable.
+<Über>
+ <Québec διακριτικός sueño="">
+ Guten Tag!
+ </Québec>
+</Über>