summaryrefslogtreecommitdiff
path: root/tests/i_e2image/script
diff options
context:
space:
mode:
authorAndreas Dilger <adilger@whamcloud.com>2012-05-28 16:58:24 -0600
committerTheodore Ts'o <tytso@mit.edu>2012-05-29 08:41:26 -0400
commitf3331df6bb5d380efd72e07fc9b40c998b355412 (patch)
tree0749c4d2caf89f4eb5f1e0916d2eefea35302c64 /tests/i_e2image/script
parent182acd17bef0cf8dcb66568448a528abb1dfcd71 (diff)
downloade2fsprogs-f3331df6bb5d380efd72e07fc9b40c998b355412.tar.gz
tests: use make rules to run tests in parallel
Change the e2fsck/mke2fs/tune2fs/e2image/debugfs regression tests to be driven by Makefile rules instead of by a script loop. This allows the tests to be run in parallel like a build and reduces testing time significantly. One major change to the tests themselves is to printing the test name, description, and status together after the test has passed or failed, to avoid mixing lines from the tests. The other major change is to use unique temporary filenames for each test, which was mostly handled already via b4db1e4c7461a50e18c9fd135b9f1ba6f27e4390, but in some cases temporary files are changed to use $test_name.tmp to avoid any collision between running tests. On my old 2-CPU system it reduced the testing time from 160s to 40s. Much of the savings is from the MMP test delays running in parallel. It still takes the time of the slowest test, f_mmp_garbage, though there will be ongoing benefit in the future as more tests are added since the wallclock time will not increase linearly for each test. Tests were run with various combinations of "make -j", and "make -j2" through "make -j44" repeatedly without any test failures. Signed-off-by: Andreas Dilger <adilger@whamcloud.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'tests/i_e2image/script')
-rw-r--r--tests/i_e2image/script13
1 files changed, 5 insertions, 8 deletions
diff --git a/tests/i_e2image/script b/tests/i_e2image/script
index 9c6ae2af..0315ae20 100644
--- a/tests/i_e2image/script
+++ b/tests/i_e2image/script
@@ -1,4 +1,4 @@
-printf "Create/convert raw and qcow2 disk images: "
+test_description="create/convert raw/qcow2 images"
if test -x $E2IMAGE_EXE; then
ORIG_IMAGES="image1024.orig image2048.orig image4096.orig"
@@ -8,7 +8,7 @@ QCOW2_IMG=_image.qcow2
QCOW2_TO_RAW=_image.qcow2.raw
OUT=$test_name.log
MD5=$SRCDIR/$test_name/$test_name.md5
-MD5_TMP=$test_name.md5tmp
+MD5_TMP=$test_name.md5.tmp
rm -f $test_name/_image.* $MD5_TMP $OUT >/dev/null 2>&1
@@ -43,18 +43,15 @@ echo "" >> $OUT
diff $MD5 $MD5_TMP >> $OUT 2>&1
if [ $? -eq 0 ]; then
- echo "ok"
+ echo "$test_name: $test_description: ok"
touch $test_name.ok
- rm -f $test_name.failed
else
- rm -f $test_name.ok
ln -f $test_name.log $test_name.failed
- echo "failed"
+ echo "$test_name: $test_description: failed"
fi
rm -f _image.* $MD5_TMP >/dev/null 2>&1
else #if test -x $E2IMAGE_EXE; then
- rm -f $test_name.ok $test_name.failed
- echo "skipped"
+ echo "$test_name: $test_description: skipped"
fi