diff options
| author | Jim Meyering <jim@meyering.net> | 2009-02-23 18:07:50 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2009-03-08 20:37:12 -0400 |
| commit | 45e338f5332a54295893dba2e32cc093d1316f60 (patch) | |
| tree | f20a569662c01e9330b33ea9fd8baa83c7601473 /e2fsck/dirinfo.c | |
| parent | a6d4aa147415acf875300176c5ca98ca72594bec (diff) | |
| download | e2fsprogs-45e338f5332a54295893dba2e32cc093d1316f60.tar.gz | |
remove useless if-before-free tests
In case you're wondering about whether this change is safe from a
portability standpoint, fear not. This has been beaten to death
in other forums. Here are a few threads:
http://thread.gmane.org/gmane.comp.version-control.git/74187
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/12712
http://thread.gmane.org/gmane.emacs.devel/98144
http://thread.gmane.org/gmane.comp.lib.glibc.alpha/13092
There has been debate about whether it's a good idea from a
performance standpoint, too, but imho you'll have a hard time
finding an instance where this sort of change induces a
measurable performance penalty. If you do, please let me know.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'e2fsck/dirinfo.c')
| -rw-r--r-- | e2fsck/dirinfo.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/e2fsck/dirinfo.c b/e2fsck/dirinfo.c index f583c62f..fb2887be 100644 --- a/e2fsck/dirinfo.c +++ b/e2fsck/dirinfo.c @@ -326,8 +326,7 @@ extern struct dir_info_iter *e2fsck_dir_info_iter_begin(e2fsck_t ctx) extern void e2fsck_dir_info_iter_end(e2fsck_t ctx EXT2FS_ATTR((unused)), struct dir_info_iter *iter) { - if (iter->tdb_iter.dptr) - free(iter->tdb_iter.dptr); + free(iter->tdb_iter.dptr); ext2fs_free_mem(&iter); } |