summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRick Bell <richard.s.bell@intel.com>2016-01-04 12:43:57 -0800
committerRick Bell <richard.s.bell@intel.com>2016-01-04 12:43:57 -0800
commitd045708ef41cb65b14cc4113fe8e2242642f91d7 (patch)
treee2ff0f727049486dc1260d95822d37a1e4cc3e9d
parent38651783914c76bd861f7fe8651b25e3986d7be8 (diff)
parent2a09e2b15e7493256de4f40331ce6be4e1fe90f4 (diff)
downloaddleyna-server-d045708ef41cb65b14cc4113fe8e2242642f91d7.tar.gz
Merge pull request #151 from debarshiray/master
Fix possible use-after-free on exit
-rw-r--r--libdleyna/server/server.c5
-rwxr-xr-xlibdleyna/server/upnp.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/libdleyna/server/server.c b/libdleyna/server/server.c
index ec725de..8653361 100644
--- a/libdleyna/server/server.c
+++ b/libdleyna/server/server.c
@@ -1352,12 +1352,15 @@ static void prv_control_point_stop_service(void)
{
uint i;
- if (g_context.manager)
+ if (g_context.manager) {
dls_manager_delete(g_context.manager);
+ g_context.manager = NULL;
+ }
if (g_context.upnp) {
dls_upnp_unsubscribe(g_context.upnp);
dls_upnp_delete(g_context.upnp);
+ g_context.upnp = NULL;
}
if (g_context.connection) {
diff --git a/libdleyna/server/upnp.c b/libdleyna/server/upnp.c
index 6d6c696..dcf31d9 100755
--- a/libdleyna/server/upnp.c
+++ b/libdleyna/server/upnp.c
@@ -547,6 +547,9 @@ dls_upnp_t *dls_upnp_new(dleyna_connector_id_t connection,
void dls_upnp_delete(dls_upnp_t *upnp)
{
if (upnp) {
+ g_signal_handlers_disconnect_by_func (G_OBJECT (upnp->context_manager),
+ G_CALLBACK(prv_on_context_available),
+ upnp);
g_object_unref(upnp->context_manager);
g_hash_table_unref(upnp->property_map);
g_hash_table_unref(upnp->filter_map);