engine, gsettings: prevent empty changesets

We should not send empty changesets to the service so just ignore them
when we get them.

This now means that an empty 'dconf load' will not send any D-Bus
messages (and will not cause D-Bus activation).

1 files changed, 11 insertions, 0 deletions

diff --git a/engine/dconf-engine.c b/engine/dconf-engine.c
index 45e1d66..446619e 100644
--- a/engine/dconf-engine.c
+++ b/engine/dconf-engine.c
@@ -1029,6 +1029,9 @@ dconf_engine_change_fast (DConfEngine     *engine,
 {
   GList *node;
 
+  if (dconf_changeset_is_empty (changeset))
+    return TRUE;
+
   if (!dconf_engine_changeset_changes_only_writable_keys (engine, changeset, error))
     return FALSE;
 
@@ -1091,6 +1094,14 @@ dconf_engine_change_sync (DConfEngine     *engine,
 {
   GVariant *reply;
 
+  if (dconf_changeset_is_empty (changeset))
+    {
+      if (tag)
+        *tag = g_strdup ("");
+
+      return TRUE;
+    }
+
   if (!dconf_engine_changeset_changes_only_writable_keys (engine, changeset, error))
     return FALSE;