DBusConnection: ref the connection in the timeout handler

client_timeout_callback in bus/test.c refs the connection across the
timeout invocation, which looks suspiciously like a workaround. If we
make the timeout handler itself ref the connection, we won't need that,
and can simplify timeout handling drastically.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33342
Reviewed-by: Thiago Macieira <thiago@kde.org>

1 files changed, 0 insertions, 4 deletions

diff --git a/bus/test.c b/bus/test.c
index 6efad6e0..95c7cfb8 100644
--- a/bus/test.c
+++ b/bus/test.c
@@ -76,12 +76,8 @@ client_timeout_callback (DBusTimeout   *timeout,
 {
   DBusConnection *connection = data;
 
-  dbus_connection_ref (connection);
-
   /* can return FALSE on OOM but we just let it fire again later */
   dbus_timeout_handle (timeout);
-
-  dbus_connection_unref (connection);
 }
 
 static dbus_bool_t