summaryrefslogtreecommitdiff
path: root/bus/bus.c
diff options
context:
space:
mode:
authorAlban Crequy <alban.crequy@collabora.co.uk>2014-07-21 17:34:08 +0100
committerSimon McVittie <simon.mcvittie@collabora.co.uk>2014-09-15 12:29:30 +0100
commitbbf11cd5f92064c7c8af61ad4d9ff41f3a039abc (patch)
tree0af92fe58a66363f1c608d8e6f81f18a861a6970 /bus/bus.c
parent8ad179a8dad789fc6a5402780044bc0ec3d41115 (diff)
downloaddbus-bbf11cd5f92064c7c8af61ad4d9ff41f3a039abc.tar.gz
config: add new limit: pending_fd_timeout
This is one of four commits needed to address CVE-2014-3637. When a file descriptor is passed to dbus-daemon, the associated D-Bus message might not be fully sent to dbus-daemon yet. Dbus-daemon keeps the file descriptor in the DBusMessageLoader of the connection, waiting for the rest of the message. If the client stops sending the remaining bytes, dbus-daemon will wait forever and keep that file descriptor. This patch adds pending_fd_timeout (milliseconds) in the configuration to disconnect a connection after a timeout when a file descriptor was sent but not the remaining message. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=80559 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Diffstat (limited to 'bus/bus.c')
-rw-r--r--bus/bus.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/bus/bus.c b/bus/bus.c
index a3dce244..35d40754 100644
--- a/bus/bus.c
+++ b/bus/bus.c
@@ -1241,6 +1241,12 @@ bus_context_get_auth_timeout (BusContext *context)
}
int
+bus_context_get_pending_fd_timeout (BusContext *context)
+{
+ return context->limits.pending_fd_timeout;
+}
+
+int
bus_context_get_max_completed_connections (BusContext *context)
{
return context->limits.max_completed_connections;