Refactor module state to always use struct (#5056)

First part of https://github.com/cython/cython/issues/3689
First part of https://github.com/cython/cython/issues/4495

This tries to put all the global static variables into the
module state struct. When CYTHON_USE_MODULE_STATE is false,
they're looked up from a single static instance of the struct.
This allows a lot of semi-duplicated code to be dropped.

It doesn't get rid of the awkward `#defines` to access the
struct (that's probably the next step of the cleanup).

It moves the stringtab from a global into a function local.

It moves the statically defined coroutine types into the
module state struct in the same way that CyFunction/FusedFunction
already were.

It's mostly an exercise in deleting things - it doesn't
attempt to do any significant cleanup of the generation code.

1 files changed, 0 insertions, 6 deletions

diff --git a/Cython/Utility/StringTools.c b/Cython/Utility/StringTools.c
index 910fbf6fa..6b192a1d9 100644
--- a/Cython/Utility/StringTools.c
+++ b/Cython/Utility/StringTools.c
@@ -43,11 +43,7 @@ static CYTHON_INLINE Py_ssize_t __Pyx_Py_UNICODE_ssize_strlen(const Py_UNICODE *
 
 //////////////////// InitStrings.proto ////////////////////
 
-#if CYTHON_COMPILING_IN_LIMITED_API
-static int __Pyx_InitString(__Pyx_StringTabEntry t, PyObject **str); /*proto*/
-#else
 static int __Pyx_InitStrings(__Pyx_StringTabEntry *t); /*proto*/
-#endif
 
 //////////////////// InitStrings ////////////////////
 
@@ -73,7 +69,6 @@ static int __Pyx_InitString(__Pyx_StringTabEntry t, PyObject **str) {
 }
 #endif
 
-#if !CYTHON_COMPILING_IN_LIMITED_API
 static int __Pyx_InitStrings(__Pyx_StringTabEntry *t) {
     while (t->p) {
         #if PY_MAJOR_VERSION >= 3  /* Python 3+ has unicode identifiers */
@@ -96,7 +91,6 @@ static int __Pyx_InitStrings(__Pyx_StringTabEntry *t) {
     }
     return 0;
 }
-#endif
 
 //////////////////// BytesContains.proto ////////////////////