summaryrefslogtreecommitdiff
path: root/tests/runtests.pl
diff options
context:
space:
mode:
authorDan Fandrich <dan@coneharvesters.com>2017-05-13 19:04:10 +0200
committerDan Fandrich <dan@coneharvesters.com>2017-05-13 19:12:22 +0200
commitfa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a (patch)
treed74cd727f8292b96b4909ed24ec4f9b4de3e3d76 /tests/runtests.pl
parent6d49695bcabe14108056c429cffdaee950242318 (diff)
downloadcurl-fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a.tar.gz
tests: made a couple of prechecks consistent with others
Also removed a TODO suggesting caching the precheck results. Tests showed this would save about 0.1 sec on the total test run time on a relatively modern system, an unnoticeable gain at the cost of longer and more complicated code. There would also be a danger that a cached test result would be inappropriately returned, such as when other test dependencies (like environment variables) are different or when the precheck causes side effects (like filesystem changes).
Diffstat (limited to 'tests/runtests.pl')
-rwxr-xr-xtests/runtests.pl5
1 files changed, 0 insertions, 5 deletions
diff --git a/tests/runtests.pl b/tests/runtests.pl
index d20383ae8..f23fc1d68 100755
--- a/tests/runtests.pl
+++ b/tests/runtests.pl
@@ -3279,11 +3279,6 @@ sub singletest {
}
if(!$why) {
- # TODO:
- # Add a precheck cache. If a precheck command was already invoked
- # exactly like this, then use the previous result to speed up
- # successive test invokes!
-
my @precheck = getpart("client", "precheck");
if(@precheck) {
$cmd = $precheck[0];