From fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Sat, 13 May 2017 19:04:10 +0200 Subject: tests: made a couple of prechecks consistent with others Also removed a TODO suggesting caching the precheck results. Tests showed this would save about 0.1 sec on the total test run time on a relatively modern system, an unnoticeable gain at the cost of longer and more complicated code. There would also be a danger that a cached test result would be inappropriately returned, such as when other test dependencies (like environment variables) are different or when the precheck causes side effects (like filesystem changes). --- tests/runtests.pl | 5 ----- 1 file changed, 5 deletions(-) (limited to 'tests/runtests.pl') diff --git a/tests/runtests.pl b/tests/runtests.pl index d20383ae8..f23fc1d68 100755 --- a/tests/runtests.pl +++ b/tests/runtests.pl @@ -3279,11 +3279,6 @@ sub singletest { } if(!$why) { - # TODO: - # Add a precheck cache. If a precheck command was already invoked - # exactly like this, then use the previous result to speed up - # successive test invokes! - my @precheck = getpart("client", "precheck"); if(@precheck) { $cmd = $precheck[0]; -- cgit v1.2.1