diff options
| author | Viktor Szakats <commit@vsz.me> | 2022-12-02 15:20:41 +0000 |
|---|---|---|
| committer | Viktor Szakats <commit@vsz.me> | 2022-12-02 15:20:41 +0000 |
| commit | 8fc24233388d91193afa8d438a91a058673411c8 (patch) | |
| tree | 5935327dbd87e6d02e01ad4eb9f379e7e777c7f4 /src | |
| parent | 73c4f9696adc77a47a79f215de99a00fe0dbee5a (diff) | |
| download | curl-8fc24233388d91193afa8d438a91a058673411c8.tar.gz | |
Makefile.mk: address minor issues
- Fix `NROFF` auto-detection with certain shell/make-build combinations:
When a non-MSYS2 GNU Make runs inside an MSYS2 shell, Make executes
the detection command as-is via `CreateProcess()`. It fails because
`command` is an `sh` built-in. Ensure to explicitly invoke the shell.
- Initialize user-customizable variables:
Silences a list of warnings when running GNU Make with the option
`--warn-undefined-variables`. Another benefit is that it's now easy
to look up all user-customizable `Makefile.mk` variables by grepping
for ` ?=` in the curl source tree.
Suggested-by: Gisle Vanem
Ref: https://github.com/curl/curl/pull/9764#issuecomment-1330674433
- Fix `MKDIR` invocation:
Avoid a warning and potential issue in envs without forward-slash
support.
Closes #10000
Diffstat (limited to 'src')
| -rw-r--r-- | src/Makefile.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/Makefile.mk b/src/Makefile.mk index 31e4d22a2..f34d97d16 100644 --- a/src/Makefile.mk +++ b/src/Makefile.mk @@ -84,7 +84,7 @@ NROFF ?= groff TOCLEAN += tool_hugehelp.c -ifneq ($(shell $(WHICH) $(NROFF)),) +ifneq ($(shell $(call WHICH, $(NROFF))),) $(PROOT)/docs/curl.1: $(wildcard $(PROOT)/docs/cmdline-opts/*.d) cd $(PROOT)/docs/cmdline-opts && \ $(PERL) gen.pl mainpage $(notdir $^) > ../curl.1 |