checksrc: fix SPACEBEFOREPAREN for conditions starting with "*"

The open paren check wants to warn for spaces before open parenthesis
for if/while/for but also for any function call. In order to avoid
catching function pointer declarations, the logic allows a space if the
first character after the open parenthesis is an asterisk.

I also spotted what we did not include "switch" in the check but we should.

This check is a little lame, but we reduce this problem by not allowing
that space for if/while/for/switch.

Reported-by: Emanuele Torre
Closes #11044

10 files changed, 11 insertions, 11 deletions

diff --git a/lib/cf-h1-proxy.c b/lib/cf-h1-proxy.c
index 700c199b1..b42c4e605 100644
--- a/lib/cf-h1-proxy.c
+++ b/lib/cf-h1-proxy.c
@@ -1096,7 +1096,7 @@ static CURLcode cf_h1_proxy_connect(struct Curl_cfilter *cf,
 
 out:
   *done = (result == CURLE_OK) && tunnel_is_established(cf->ctx);
-  if (*done) {
+  if(*done) {
     cf->connected = TRUE;
     tunnel_free(cf, data);
   }
diff --git a/lib/cfilters.c b/lib/cfilters.c
index a839f7910..067de23cc 100644
--- a/lib/cfilters.c
+++ b/lib/cfilters.c
@@ -293,8 +293,8 @@ bool Curl_conn_cf_discard_sub(struct Curl_cfilter *cf,
 
   /* remove from sub-chain and destroy */
   DEBUGASSERT(cf);
-  while (*pprev) {
-    if (*pprev == cf) {
+  while(*pprev) {
+    if(*pprev == cf) {
       *pprev = discard->next;
       discard->next = NULL;
       found = TRUE;
diff --git a/lib/connect.c b/lib/connect.c
index 87f5b2ed1..78446bdd5 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -548,7 +548,7 @@ static CURLcode baller_connect(struct Curl_cfilter *cf,
     baller->result = Curl_conn_cf_connect(baller->cf, data, 0, connected);
 
     if(!baller->result) {
-      if (*connected) {
+      if(*connected) {
         baller->connected = TRUE;
         baller->is_done = TRUE;
       }
diff --git a/lib/ftp.c b/lib/ftp.c
index 4ff68cc45..c868c2b6e 100644
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -4180,7 +4180,7 @@ CURLcode ftp_parse_url_path(struct Curl_easy *data)
       size_t dirAlloc = 0;
       const char *str = rawPath;
       for(; *str != 0; ++str)
-        if (*str == '/')
+        if(*str == '/')
           ++dirAlloc;
 
       if(dirAlloc) {
diff --git a/lib/hsts.c b/lib/hsts.c
index 64cbae10c..661bf4d75 100644
--- a/lib/hsts.c
+++ b/lib/hsts.c
@@ -204,7 +204,7 @@ CURLcode Curl_hsts_parse(struct hsts *h, const char *hostname,
       p++;
     if(*p == ';')
       p++;
-  } while (*p);
+  } while(*p);
 
   if(!gotma)
     /* max-age is mandatory */
diff --git a/lib/http_aws_sigv4.c b/lib/http_aws_sigv4.c
index 7d50cfff8..806016253 100644
--- a/lib/http_aws_sigv4.c
+++ b/lib/http_aws_sigv4.c
@@ -192,7 +192,7 @@ static CURLcode make_headers(struct Curl_easy *data,
   }
 
 
-  if (*content_sha256_header) {
+  if(*content_sha256_header) {
     tmp_head = curl_slist_append(head, content_sha256_header);
     if(!tmp_head)
       goto fail;
diff --git a/lib/mprintf.c b/lib/mprintf.c
index 5de935b1f..8e830438d 100644
--- a/lib/mprintf.c
+++ b/lib/mprintf.c
@@ -400,7 +400,7 @@ static int dprintf_Pass1(const char *format, struct va_stack *vto,
         /* out of allowed range */
         return 1;
 
-      switch (*fmt) {
+      switch(*fmt) {
       case 'S':
         flags |= FLAGS_ALT;
         /* FALLTHROUGH */
diff --git a/lib/urlapi.c b/lib/urlapi.c
index 192fb165b..8b95107d2 100644
--- a/lib/urlapi.c
+++ b/lib/urlapi.c
@@ -678,7 +678,7 @@ static int ipv4_normalize(struct dynbuf *host)
     parts[n] = l;
     c = endp;
 
-    switch (*c) {
+    switch(*c) {
     case '.' :
       if(n == 3)
         return HOST_BAD;
diff --git a/lib/vtls/bearssl.c b/lib/vtls/bearssl.c
index a3a557c48..2b666ca6f 100644
--- a/lib/vtls/bearssl.c
+++ b/lib/vtls/bearssl.c
@@ -897,7 +897,7 @@ static ssize_t bearssl_send(struct Curl_cfilter *cf, struct Curl_easy *data,
 
   for(;;) {
     *err = bearssl_run_until(cf, data, BR_SSL_SENDAPP);
-    if (*err != CURLE_OK)
+    if(*err)
       return -1;
     app = br_ssl_engine_sendapp_buf(&backend->ctx.eng, &applen);
     if(!app) {
diff --git a/lib/vtls/sectransp.c b/lib/vtls/sectransp.c
index d59f2a8c0..618c0c586 100644
--- a/lib/vtls/sectransp.c
+++ b/lib/vtls/sectransp.c
@@ -1554,7 +1554,7 @@ static CURLcode sectransp_set_selected_ciphers(struct Curl_easy *data,
     }
     /* Find last position of a cipher in the ciphers string */
     cipher_end = cipher_start;
-    while (*cipher_end != '\0' && !is_separator(*cipher_end)) {
+    while(*cipher_end != '\0' && !is_separator(*cipher_end)) {
       ++cipher_end;
     }