diff options
| author | Stefan Eissing <stefan@eissing.org> | 2023-02-08 10:26:58 +0100 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2023-02-09 09:13:30 +0100 |
| commit | 3de3ea6a646687de2bf4154ce647485a84e1c6f9 (patch) | |
| tree | 2750c4c0af3d745157e6ff5548039027ba7cca81 /lib/transfer.c | |
| parent | 8c762f59983a3e9e2b80fdb34aa5e08f1d9a1c7d (diff) | |
| download | curl-3de3ea6a646687de2bf4154ce647485a84e1c6f9.tar.gz | |
HTTP/[23]: continue upload when state.drain is set
- as reported in #10433, HTTP/2 uploads may stall when a response is
received before the upload is done. This happens when the
data->state.drain is set for such a transfer, as the special handling
in transfer.c from then on only cared about downloads.
- add continuation of uploads, if applicable, in this case.
- add pytest case test_07_12_upload_seq_large to reproduce this scenario
(although, current nghttp2 implementation is using drain less often)
Reported-by: Lucas Pardue
Fixes #10433
Closes #10443
Diffstat (limited to 'lib/transfer.c')
| -rw-r--r-- | lib/transfer.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/transfer.c b/lib/transfer.c index 75e002547..151aab127 100644 --- a/lib/transfer.c +++ b/lib/transfer.c @@ -1080,6 +1080,8 @@ CURLcode Curl_readwrite(struct connectdata *conn, if(data->state.drain) { select_res |= CURL_CSELECT_IN; DEBUGF(infof(data, "Curl_readwrite: forcibly told to drain data")); + if((k->keepon & KEEP_SENDBITS) == KEEP_SEND) + select_res |= CURL_CSELECT_OUT; } #endif |