summaryrefslogtreecommitdiff
path: root/lib/doh.c
diff options
context:
space:
mode:
authorJay Satiro <raysatiro@yahoo.com>2021-02-27 16:27:31 -0500
committerJay Satiro <raysatiro@yahoo.com>2021-04-22 16:53:37 -0400
commit54e747501626b81149b1b44949119d365db82004 (patch)
tree6c89f73c8eb7bbb96877a83e27b3b3916d5534e7 /lib/doh.c
parente4ba999646ed7a974813ecf8405651d300554eba (diff)
downloadcurl-54e747501626b81149b1b44949119d365db82004.tar.gz
schannel: Disable auto credentials; add an option to enable it
- Disable auto credentials by default. This is a breaking change for clients that are using it, wittingly or not. - New libcurl ssl option value CURLSSLOPT_AUTO_CLIENT_CERT tells libcurl to automatically locate and use a client certificate for authentication, when requested by the server. - New curl tool options --ssl-auto-client-cert and --proxy-ssl-auto-client-cert map to CURLSSLOPT_AUTO_CLIENT_CERT. This option is only supported for Schannel (the native Windows SSL library). Prior to this change Schannel would, with no notification to the client, attempt to locate a client certificate and send it to the server, when requested by the server. Since the server can request any certificate that supports client authentication in the OS certificate store it could be a privacy violation and unexpected. Fixes https://github.com/curl/curl/issues/2262 Reported-by: Jeroen Ooms Assisted-by: Wes Hinsley Assisted-by: Rich FitzJohn Ref: https://curl.se/mail/lib-2021-02/0066.html Reported-by: Morten Minde Neergaard Closes https://github.com/curl/curl/pull/6673
Diffstat (limited to 'lib/doh.c')
-rw-r--r--lib/doh.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/doh.c b/lib/doh.c
index 52388cba3..8ea53ff8d 100644
--- a/lib/doh.c
+++ b/lib/doh.c
@@ -351,7 +351,10 @@ static CURLcode dohprobe(struct Curl_easy *data,
(data->set.ssl.revoke_best_effort ?
CURLSSLOPT_REVOKE_BEST_EFFORT : 0) |
(data->set.ssl.native_ca_store ?
- CURLSSLOPT_NATIVE_CA : 0);
+ CURLSSLOPT_NATIVE_CA : 0) |
+ (data->set.ssl.auto_client_cert ?
+ CURLSSLOPT_AUTO_CLIENT_CERT : 0);
+
curl_easy_setopt(doh, CURLOPT_SSL_OPTIONS, mask);
}