diff options
author | JDepooter <joel.depooter@safe.com> | 2017-02-02 13:40:16 -0800 |
---|---|---|
committer | Jay Satiro <raysatiro@yahoo.com> | 2017-02-07 02:39:13 -0500 |
commit | 18495ecaccf936a9d7d6c96c08c644ceda83bd00 (patch) | |
tree | 8546ab1b1a68163d3438bb167000c1160daea7c2 | |
parent | 5aef498b8a76a1425e448677544fa70229eb27a9 (diff) | |
download | curl-18495ecaccf936a9d7d6c96c08c644ceda83bd00.tar.gz |
schannel: Remove incorrect SNI disabled message
- Remove the SNI disabled when host verification disabled message
since that is incorrect.
- Show a message for legacy versions of Windows <= XP that connections
may fail since those versions of WinSSL lack SNI, algorithms, etc.
Bug: https://github.com/curl/curl/pull/1240
-rw-r--r-- | lib/vtls/schannel.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/lib/vtls/schannel.c b/lib/vtls/schannel.c index ca7545662..bd9239956 100644 --- a/lib/vtls/schannel.c +++ b/lib/vtls/schannel.c @@ -130,6 +130,14 @@ schannel_connect_step1(struct connectdata *conn, int sockindex) infof(data, "schannel: SSL/TLS connection with %s port %hu (step 1/3)\n", hostname, conn->remote_port); + if(Curl_verify_windows_version(5, 1, PLATFORM_WINNT, + VERSION_LESS_THAN_EQUAL)) { + /* SChannel in Windows XP (OS version 5.1) uses legacy handshakes and + algorithms that may not be supported by all servers. */ + infof(data, "schannel: WinSSL version is old and may not be able to " + "connect to some servers due to lack of SNI, algorithms, etc.\n"); + } + #ifdef HAS_ALPN /* ALPN is only supported on Windows 8.1 / Server 2012 R2 and above. Also it doesn't seem to be supported for Wine, see curl bug #983. */ @@ -197,7 +205,7 @@ schannel_connect_step1(struct connectdata *conn, int sockindex) schannel_cred.dwFlags |= SCH_CRED_NO_SERVERNAME_CHECK; infof(data, "schannel: verifyhost setting prevents Schannel from " "comparing the supplied target name with the subject " - "names in server certificates. Also disables SNI.\n"); + "names in server certificates.\n"); } switch(conn->ssl_config.version) { |