summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2021-03-22 11:55:27 +0100
committerDaniel Stenberg <daniel@haxx.se>2021-03-22 13:17:10 +0100
commit1042dfd6f89c00d4e101109dc0b1ffdb42ac994b (patch)
tree179a3ff71268749933882c24b4f6ad152b810fc2
parentc915662485f8fe1e32351a8f83a4a5fe76b5bd08 (diff)
downloadcurl-bagder/curl-ssl-ignored.tar.gz
curl: ignore options asking for SSLv2 or SSLv3bagder/curl-ssl-ignored
Instead output a warning about it and continue with the defaults. These SSL versions are typically not supported by the TLS libraries since a long time back already since they are inherently insecure and broken. Asking for them to be used will just cause an error to be returned slightly later. In the unlikely event that a user's TLS library actually still supports these protocol versions, this change might make the request a little less insecure.
-rw-r--r--docs/cmdline-opts/sslv2.d5
-rw-r--r--docs/cmdline-opts/sslv3.d6
-rw-r--r--src/tool_getparam.c4
3 files changed, 7 insertions, 8 deletions
diff --git a/docs/cmdline-opts/sslv2.d b/docs/cmdline-opts/sslv2.d
index 773ab691e..f9ee99d0d 100644
--- a/docs/cmdline-opts/sslv2.d
+++ b/docs/cmdline-opts/sslv2.d
@@ -9,6 +9,5 @@ See-also: http1.1 http2
Help: Use SSLv2
Category: tls
---
-Forces curl to use SSL version 2 when negotiating with a remote SSL
-server. Sometimes curl is built without SSLv2 support. SSLv2 is widely
-considered insecure (see RFC 6176).
+This option previously asked curl to use SSLv2, but starting in curl 7.77.0 this
+instruction is ignored. SSLv2 is widely considered insecure (see RFC 6176).
diff --git a/docs/cmdline-opts/sslv3.d b/docs/cmdline-opts/sslv3.d
index 7beed8f81..e8b2c35e8 100644
--- a/docs/cmdline-opts/sslv3.d
+++ b/docs/cmdline-opts/sslv3.d
@@ -9,6 +9,6 @@ See-also: http1.1 http2
Help: Use SSLv3
Category: tls
---
-Forces curl to use SSL version 3 when negotiating with a remote SSL
-server. Sometimes curl is built without SSLv3 support. SSLv3 is widely
-considered insecure (see RFC 7568).
+This option previously asked curl to use SSLv3, but starting in curl 7.77.0
+this instruction is ignored. SSLv3 is widely considered insecure (see RFC
+7568).
diff --git a/src/tool_getparam.c b/src/tool_getparam.c
index f1393c373..55902f98e 100644
--- a/src/tool_getparam.c
+++ b/src/tool_getparam.c
@@ -1278,11 +1278,11 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
break;
case '2':
/* SSL version 2 */
- config->ssl_version = CURL_SSLVERSION_SSLv2;
+ warnf(global, "Ignores instruction to use SSLv2\n");
break;
case '3':
/* SSL version 3 */
- config->ssl_version = CURL_SSLVERSION_SSLv3;
+ warnf(global, "Ignores instruction to use SSLv3\n");
break;
case '4':
/* IPv4 */