diff options
| author | Dan Fandrich <dan@coneharvesters.com> | 2023-03-10 16:41:25 -0800 |
|---|---|---|
| committer | Dan Fandrich <dan@coneharvesters.com> | 2023-03-10 16:41:25 -0800 |
| commit | c2b7249db213cd5c5debf8d8b6be23003a4cf200 (patch) | |
| tree | 41e3123f4ecbd19d435435fe91105de7c21c303a /.github | |
| parent | 544a7f804d176d97a7c505d5ab689aa83e583427 (diff) | |
| download | curl-c2b7249db213cd5c5debf8d8b6be23003a4cf200.tar.gz | |
CI: fix retrying on brew failures
The previous attempt didn't consider that the shell would exit
immediately after the false statement in the retry case.
Follow-up to dc141a37
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/macos.yml | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 16077e7d8..e50011e54 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -96,7 +96,7 @@ jobs: # Run this command with retries because of spurious failures seen # while running the tests, for example # https://github.com/curl/curl/runs/4095721123?check_suite_focus=true - - run: "for i in 1 2 3; do brew update && brew bundle install --no-lock --file /tmp/Brewfile && break || { echo Error: wait to try again; sleep 10; false; } done" + - run: "while [[ $? == 0 ]]; do for i in 1 2 3; do brew update && brew bundle install --no-lock --file /tmp/Brewfile && break 2 || { echo Error: wait to try again; sleep 10; false; } done; false Too many retries; done" name: 'brew install' - run: python3 -m pip install impacket @@ -155,7 +155,7 @@ jobs: - run: echo libtool autoconf automake pkg-config ${{ matrix.build.install }} | xargs -Ix -n1 echo brew '"x"' > /tmp/Brewfile name: 'brew bundle' - - run: "for i in 1 2 3; do brew update && brew bundle install --no-lock --file /tmp/Brewfile && break || { echo Error: wait to try again; sleep 10; false; } done" + - run: "while [[ $? == 0 ]]; do for i in 1 2 3; do brew update && brew bundle install --no-lock --file /tmp/Brewfile && break 2 || { echo Error: wait to try again; sleep 10; false; } done; false Too many retries; done" name: 'brew install' - run: python3 -m pip install impacket |