diff options
| author | Jeffrey Walton <noloader@gmail.com> | 2017-08-19 09:09:21 -0400 |
|---|---|---|
| committer | Jeffrey Walton <noloader@gmail.com> | 2017-08-19 09:09:21 -0400 |
| commit | 29f404ba5cc9ea9335ee3c698ff52f151887c2e7 (patch) | |
| tree | 8e6cc0b806d64a77e37788d4271762d5e1bbbbdb /zinflate.cpp | |
| parent | f47022b4dda9ac0aecd1bc86b5e6f2215cca3031 (diff) | |
| download | cryptopp-git-29f404ba5cc9ea9335ee3c698ff52f151887c2e7.tar.gz | |
Update comments (Issue 414)
After more investigation it appears the issue was either Undefined Behavior or a Strict Aliasing violation in GCC; and it was in the test program and not the library. We're not sure which at the moment, but we were able to identify the problematic code. See the comments with Issue 414 (https://github.com/weidai11/cryptopp/issues/414)
Diffstat (limited to 'zinflate.cpp')
| -rw-r--r-- | zinflate.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/zinflate.cpp b/zinflate.cpp index 41690ef9..7e9de15b 100644 --- a/zinflate.cpp +++ b/zinflate.cpp @@ -556,7 +556,6 @@ bool Inflator::DecodeBody() break;
}
case DISTANCE_BITS:
- // TODO: this surfaced during fuzzing. What do we do???
CRYPTOPP_ASSERT(m_distance < COUNTOF(distanceExtraBits));
if (m_distance >= COUNTOF(distanceExtraBits))
throw BadDistanceErr();
@@ -566,7 +565,6 @@ bool Inflator::DecodeBody() m_nextDecode = DISTANCE_BITS;
break;
}
- // TODO: this surfaced during fuzzing. What do we do???
CRYPTOPP_ASSERT(m_distance < COUNTOF(distanceStarts));
if (m_distance >= COUNTOF(distanceStarts))
throw BadDistanceErr();
|