Fix clang warnings in headers (#655)

* remove superfluous semicolon

* Remove C-style casts from public headers

clang warns about them with -Wold-style-cast. It also warns about
implicitly casting away const with -Wcast-qual. Fix both by removing
unnecessary casts and converting the remaining ones to C++ casts.

1 files changed, 2 insertions, 2 deletions

diff --git a/crc.h b/crc.h
index f34715f6..505f88ca 100644
--- a/crc.h
+++ b/crc.h
@@ -34,7 +34,7 @@ public:
     std::string AlgorithmName() const {return StaticAlgorithmName();}

 

 	void UpdateByte(byte b) {m_crc = m_tab[CRC32_INDEX(m_crc) ^ b] ^ CRC32_SHIFTED(m_crc);}

-	byte GetCrcByte(size_t i) const {return ((byte *)&(m_crc))[i];}

+	byte GetCrcByte(size_t i) const {return reinterpret_cast<const byte *>(&m_crc)[i];}

 

 protected:

 	void Reset() {m_crc = CRC32_NEGL;}

@@ -59,7 +59,7 @@ public:
     std::string AlgorithmName() const {return StaticAlgorithmName();}

 

 	void UpdateByte(byte b) {m_crc = m_tab[CRC32_INDEX(m_crc) ^ b] ^ CRC32_SHIFTED(m_crc);}

-	byte GetCrcByte(size_t i) const {return ((byte *)&(m_crc))[i];}

+	byte GetCrcByte(size_t i) const {return reinterpret_cast<const byte *>(&m_crc)[i];}

 

 protected:

 	void Reset() {m_crc = CRC32_NEGL;}