diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2010-05-03 16:48:20 +0000 |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2010-05-03 16:48:20 +0000 |
commit | 916fe4197d8172e967b7e25d93ac9660c45ab0ea (patch) | |
tree | cce661039f8d491f968e91f70669d3f1ce24183d /Lib/_pyio.py | |
parent | 613a06a6230121f5d096940ac08200f895a7c665 (diff) | |
download | cpython-916fe4197d8172e967b7e25d93ac9660c45ab0ea.tar.gz |
Merged revisions 80720 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r80720 | antoine.pitrou | 2010-05-03 18:25:33 +0200 (lun., 03 mai 2010) | 5 lines
Issue #7865: The close() method of :mod:`io` objects should not swallow
exceptions raised by the implicit flush(). Also ensure that calling
close() several times is supported. Patch by Pascal Chambon.
........
Diffstat (limited to 'Lib/_pyio.py')
-rw-r--r-- | Lib/_pyio.py | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/Lib/_pyio.py b/Lib/_pyio.py index 1fbefd239f..66f990d79b 100644 --- a/Lib/_pyio.py +++ b/Lib/_pyio.py @@ -322,6 +322,7 @@ class IOBase(metaclass=abc.ABCMeta): This is not implemented for read-only and non-blocking streams. """ + self._checkClosed() # XXX Should this return the number of bytes written??? __closed = False @@ -332,10 +333,7 @@ class IOBase(metaclass=abc.ABCMeta): This method has no effect if the file is already closed. """ if not self.__closed: - try: - self.flush() - except IOError: - pass # If flush() fails, just give up + self.flush() self.__closed = True def __del__(self) -> None: @@ -702,14 +700,13 @@ class _BufferedIOMixin(BufferedIOBase): ### Flush and close ### def flush(self): + if self.closed: + raise ValueError("flush of closed file") self.raw.flush() def close(self): - if not self.closed and self.raw is not None: - try: - self.flush() - except IOError: - pass # If flush() fails, just give up + if self.raw is not None and not self.closed: + self.flush() self.raw.close() def detach(self): @@ -1521,11 +1518,8 @@ class TextIOWrapper(TextIOBase): self._telling = self._seekable def close(self): - if self.buffer is not None: - try: - self.flush() - except IOError: - pass # If flush() fails, just give up + if self.buffer is not None and not self.closed: + self.flush() self.buffer.close() @property |