summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Lib/subprocess.py10
-rw-r--r--Misc/NEWS3
2 files changed, 12 insertions, 1 deletions
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index ce47b5e9ad..f9e9104d45 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -1035,7 +1035,15 @@ class Popen(object):
try:
self.stdin.write(input)
except IOError as e:
- if e.errno != errno.EPIPE:
+ if e.errno == errno.EPIPE:
+ # communicate() should ignore broken pipe error
+ pass
+ elif (e.errno == errno.EINVAL
+ and self.poll() is not None):
+ # Issue #19612: stdin.write() fails with EINVAL
+ # if the process already exited before the write
+ pass
+ else:
raise
self.stdin.close()
diff --git a/Misc/NEWS b/Misc/NEWS
index f2087c5c5c..bdd414ebeb 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -13,6 +13,9 @@ Core and Builtins
Library
-------
+- Issue #19612: subprocess.communicate() now also ignores EINVAL when using at
+ least two pipes.
+
- Fix repr(_socket.socket) on Windows 64-bit: don't fail with OverflowError
on closed socket.