summaryrefslogtreecommitdiff
path: root/Objects
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-01-01 18:25:23 -0800
committerGitHub <noreply@github.com>2019-01-01 18:25:23 -0800
commita5955b0895aa011b0beff1ceb6539b2ff8888425 (patch)
tree9846b0db822b769c2c879e698addf36400ed0ba7 /Objects
parent513fab2c67365e1693216dd59e4df0a5f6bfeb26 (diff)
downloadcpython-git-a5955b0895aa011b0beff1ceb6539b2ff8888425.tar.gz
closes bpo-35623: Fix integer overflow when sorting large lists (GH-11380)
There is already a `Py_ssize_t i` defined at function scope that is used for similar loops. By removing the local `int i` declaration that `i` is used, which has the appropriate type. (cherry picked from commit f8b534477a2a51d85ea1663530f685f805f2b247) Co-authored-by: sth <sth.dev@tejp.de>
Diffstat (limited to 'Objects')
-rw-r--r--Objects/listobject.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/Objects/listobject.c b/Objects/listobject.c
index c8ffeff093..de73b8bf80 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -2232,7 +2232,6 @@ list_sort_impl(PyListObject *self, PyObject *keyfunc, int reverse)
int ints_are_bounded = 1;
/* Prove that assumption by checking every key. */
- int i;
for (i=0; i < saved_ob_size; i++) {
if (keys_are_in_tuples &&