diff options
author | Neal Norwitz <nnorwitz@gmail.com> | 2005-09-19 06:42:30 +0000 |
---|---|---|
committer | Neal Norwitz <nnorwitz@gmail.com> | 2005-09-19 06:42:30 +0000 |
commit | c36179bf814b7075fe3341807ff0eac40c55dec7 (patch) | |
tree | c7e595645ca908869b9211cb82076a2ffe2dfb36 /Modules | |
parent | 539604146aa5e33a5a1517f1a5fb4548153d77ef (diff) | |
download | cpython-git-c36179bf814b7075fe3341807ff0eac40c55dec7.tar.gz |
Fix problems reported by valgrind:
* Fix memory leak in posix.access()
* Fix use of uninitialized value in forkpty()
- from the manpage it isn't clear if there are conditions where master_fd
are uninitialized, but it's safer to initialize
Diffstat (limited to 'Modules')
-rw-r--r-- | Modules/posixmodule.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index a116c41d5e..0649854f55 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -1119,6 +1119,7 @@ posix_access(PyObject *self, PyObject *args) Py_BEGIN_ALLOW_THREADS res = access(path, mode); Py_END_ALLOW_THREADS + PyMem_Free(path); return(PyBool_FromLong(res == 0)); } @@ -2950,7 +2951,7 @@ To both, return fd of newly opened pseudo-terminal.\n"); static PyObject * posix_forkpty(PyObject *self, PyObject *noargs) { - int master_fd, pid; + int master_fd = -1, pid; pid = forkpty(&master_fd, NULL, NULL, NULL); if (pid == -1) |