summaryrefslogtreecommitdiff
path: root/Modules/termios.c
diff options
context:
space:
mode:
authorZackery Spytz <zspytz@gmail.com>2018-10-28 22:55:20 -0600
committerSerhiy Storchaka <storchaka@gmail.com>2018-10-29 06:55:20 +0200
commit53835e92d315340444e3dd083b3f69a590b00e07 (patch)
tree0a182977b6b059419e2ef16ac38a439ad33d7ef3 /Modules/termios.c
parentea9c8bd44365ae8b0accc5286c7b52862528c0ec (diff)
downloadcpython-git-53835e92d315340444e3dd083b3f69a590b00e07.tar.gz
Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)
Diffstat (limited to 'Modules/termios.c')
-rw-r--r--Modules/termios.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/Modules/termios.c b/Modules/termios.c
index b4aa77f897..7601b68afd 100644
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -119,11 +119,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
PyList_SetItem(v, 3, PyLong_FromLong((long)mode.c_lflag));
PyList_SetItem(v, 4, PyLong_FromLong((long)ispeed));
PyList_SetItem(v, 5, PyLong_FromLong((long)ospeed));
- PyList_SetItem(v, 6, cc);
- if (PyErr_Occurred()){
+ if (PyErr_Occurred()) {
Py_DECREF(v);
goto err;
}
+ PyList_SetItem(v, 6, cc);
return v;
err:
Py_DECREF(cc);