summaryrefslogtreecommitdiff
path: root/Modules/sha1module.c
diff options
context:
space:
mode:
authorHirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp>2009-03-03 07:49:01 +0000
committerHirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp>2009-03-03 07:49:01 +0000
commit8404749e4b65f23a7d84c3940ea061eee0b4b344 (patch)
treed8082d486912a2af4485d4b47dceee81bc6a3f02 /Modules/sha1module.c
parent45ed72ddaf16c97237f2ad522959d6ffd8b40e2e (diff)
downloadcpython-git-8404749e4b65f23a7d84c3940ea061eee0b4b344.tar.gz
Fixed memory leak on failure. This is related to issue5403 but won't crash on py3k.
Diffstat (limited to 'Modules/sha1module.c')
-rw-r--r--Modules/sha1module.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/Modules/sha1module.c b/Modules/sha1module.c
index a7f6ad2cba..3e630eb7b0 100644
--- a/Modules/sha1module.c
+++ b/Modules/sha1module.c
@@ -502,18 +502,23 @@ SHA1_new(PyObject *self, PyObject *args, PyObject *kwdict)
if (data_obj)
GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf);
- if ((new = newSHA1object()) == NULL)
+ if ((new = newSHA1object()) == NULL) {
+ if (data_obj)
+ PyBuffer_Release(&buf);
return NULL;
+ }
sha1_init(&new->hash_state);
if (PyErr_Occurred()) {
Py_DECREF(new);
+ if (data_obj)
+ PyBuffer_Release(&buf);
return NULL;
}
if (data_obj) {
sha1_process(&new->hash_state, buf.buf, buf.len);
- PyBuffer_Release(&buf);
+ PyBuffer_Release(&buf);
}
return (PyObject *)new;