diff options
| author | Antoine Pitrou <solipsis@pitrou.net> | 2012-11-01 20:13:54 +0100 |
|---|---|---|
| committer | Antoine Pitrou <solipsis@pitrou.net> | 2012-11-01 20:13:54 +0100 |
| commit | 0552fc2b8af80bd93f43001ce9d6b03402630ee2 (patch) | |
| tree | bac0dc2f14c661fc15642fdb9e0a82fc42eae6ef /Modules/selectmodule.c | |
| parent | e9e35c3f6b0be57f44b1dac653e6adbe23cc2e93 (diff) | |
| download | cpython-git-0552fc2b8af80bd93f43001ce9d6b03402630ee2.tar.gz | |
Issue #16230: Fix a crash in select.select() when one the lists changes size while iterated on.
Patch by Serhiy Storchaka.
Diffstat (limited to 'Modules/selectmodule.c')
| -rw-r--r-- | Modules/selectmodule.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c index 5a8580c8ac..b95b2cedc1 100644 --- a/Modules/selectmodule.c +++ b/Modules/selectmodule.c @@ -87,7 +87,6 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1]) int i; int max = -1; int index = 0; - int len = -1; PyObject* fast_seq = NULL; PyObject* o = NULL; @@ -98,9 +97,7 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1]) if (!fast_seq) return -1; - len = PySequence_Fast_GET_SIZE(fast_seq); - - for (i = 0; i < len; i++) { + for (i = 0; i < PySequence_Fast_GET_SIZE(fast_seq); i++) { SOCKET v; /* any intervening fileno() calls could decr this refcnt */ |