diff options
author | INADA Naoki <methane@users.noreply.github.com> | 2017-05-11 21:18:38 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-05-11 21:18:38 +0900 |
commit | 991adca012f5e106c2d4040ce619c696ba6f9c46 (patch) | |
tree | 90fa267454273f2e779ceffbeeae2ff84d5f01ca /Modules/_asynciomodule.c | |
parent | c4750959acbfc3057f12aaec832483ba30898d1c (diff) | |
download | cpython-git-991adca012f5e106c2d4040ce619c696ba6f9c46.tar.gz |
bpo-30048: asyncio: fix Task.cancel() was ignored. (GH-1097)
when there are no more `await` or `yield (from)` before return in coroutine,
cancel was ignored.
example:
async def coro():
asyncio.Task.current_task().cancel()
return 42
...
res = await coro() # should raise CancelledError
Diffstat (limited to 'Modules/_asynciomodule.c')
-rw-r--r-- | Modules/_asynciomodule.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c index e902c041e5..150ca198d2 100644 --- a/Modules/_asynciomodule.c +++ b/Modules/_asynciomodule.c @@ -1985,6 +1985,16 @@ task_step_impl(TaskObj *task, PyObject *exc) if (_PyGen_FetchStopIterationValue(&o) == 0) { /* The error is StopIteration and that means that the underlying coroutine has resolved */ + if (task->task_must_cancel) { + // Task is cancelled right before coro stops. + Py_DECREF(o); + task->task_must_cancel = 0; + et = asyncio_CancelledError; + Py_INCREF(et); + ev = NULL; + tb = NULL; + goto set_exception; + } PyObject *res = future_set_result((FutureObj*)task, o); Py_DECREF(o); if (res == NULL) { @@ -2002,6 +2012,8 @@ task_step_impl(TaskObj *task, PyObject *exc) /* Some other exception; pop it and call Task.set_exception() */ PyErr_Fetch(&et, &ev, &tb); + +set_exception: assert(et); if (!ev || !PyObject_TypeCheck(ev, (PyTypeObject *) et)) { PyErr_NormalizeException(&et, &ev, &tb); |