summaryrefslogtreecommitdiff
path: root/Lib
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2016-01-02 15:41:41 -0500
committerR David Murray <rdmurray@bitdance.com>2016-01-02 15:41:41 -0500
commit830207e8f32df949ec35e2e7f5afe98975e262c9 (patch)
treefaddddb33d51837ca7de7bfecb0f809d535f0255 /Lib
parentfcb6db50d3cce6337f28c9c1b891905cc323ad13 (diff)
downloadcpython-git-830207e8f32df949ec35e2e7f5afe98975e262c9.tar.gz
#22709: Use stdin as-is if it does not have a buffer attribute.
This restores backward compatibility lost in the fix for #21075, and is better duck typing. Patch by Akira Li.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/fileinput.py2
-rw-r--r--Lib/test/test_fileinput.py11
2 files changed, 12 insertions, 1 deletions
diff --git a/Lib/fileinput.py b/Lib/fileinput.py
index c41b94abff..021e39f83a 100644
--- a/Lib/fileinput.py
+++ b/Lib/fileinput.py
@@ -328,7 +328,7 @@ class FileInput:
if self._filename == '-':
self._filename = '<stdin>'
if 'b' in self._mode:
- self._file = sys.stdin.buffer
+ self._file = getattr(sys.stdin, 'buffer', sys.stdin)
else:
self._file = sys.stdin
self._isstdin = True
diff --git a/Lib/test/test_fileinput.py b/Lib/test/test_fileinput.py
index 4765a056f6..91c11668bd 100644
--- a/Lib/test/test_fileinput.py
+++ b/Lib/test/test_fileinput.py
@@ -240,6 +240,17 @@ class FileInputTests(unittest.TestCase):
lines = list(fi)
self.assertEqual(lines, [b'spam, bacon, sausage, and spam'])
+ def test_detached_stdin_binary_mode(self):
+ orig_stdin = sys.stdin
+ try:
+ sys.stdin = BytesIO(b'spam, bacon, sausage, and spam')
+ self.assertFalse(hasattr(sys.stdin, 'buffer'))
+ fi = FileInput(files=['-'], mode='rb')
+ lines = list(fi)
+ self.assertEqual(lines, [b'spam, bacon, sausage, and spam'])
+ finally:
+ sys.stdin = orig_stdin
+
def test_file_opening_hook(self):
try:
# cannot use openhook and inplace mode