diff options
author | Serhiy Storchaka <storchaka@gmail.com> | 2014-01-25 19:43:02 +0200 |
---|---|---|
committer | Serhiy Storchaka <storchaka@gmail.com> | 2014-01-25 19:43:02 +0200 |
commit | 91b0bc237c07b52c771e121098989680cfc3600d (patch) | |
tree | 96ce4b2c32292bf2f619846c1599c9af0142f2f7 /Lib/xml | |
parent | 933209689e8d07e3ce00c68ca26e001b130f0b62 (diff) | |
download | cpython-git-91b0bc237c07b52c771e121098989680cfc3600d.tar.gz |
Issue #20331: Fixed possible FD leaks in various modules:
http.server, imghdr, mailcap, mimetypes, xml.etree.
Diffstat (limited to 'Lib/xml')
-rw-r--r-- | Lib/xml/etree/ElementInclude.py | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/Lib/xml/etree/ElementInclude.py b/Lib/xml/etree/ElementInclude.py index 6cc1b44e95..71eeb05a6e 100644 --- a/Lib/xml/etree/ElementInclude.py +++ b/Lib/xml/etree/ElementInclude.py @@ -76,14 +76,13 @@ class FatalIncludeError(SyntaxError): def default_loader(href, parse, encoding=None): if parse == "xml": - file = open(href, 'rb') - data = ElementTree.parse(file).getroot() + with open(href, 'rb') as file: + data = ElementTree.parse(file).getroot() else: if not encoding: encoding = 'UTF-8' - file = open(href, 'r', encoding=encoding) - data = file.read() - file.close() + with open(href, 'r', encoding=encoding) as file: + data = file.read() return data ## |