#11866: Eliminate race condition in the computation of names for new threads.

Original patch by Peter Saveliev.

1 files changed, 4 insertions, 4 deletions

diff --git a/Lib/threading.py b/Lib/threading.py
index 0438e1f520..27a5511ddc 100644
--- a/Lib/threading.py
+++ b/Lib/threading.py
@@ -11,6 +11,7 @@ except ImportError:
 import warnings
 
 from collections import deque as _deque
+from itertools import count as _count
 from time import time as _time, sleep as _sleep
 from traceback import format_exc as _format_exc
 
@@ -623,11 +624,10 @@ class _Event(_Verbose):
             self.__cond.release()
 
 # Helper to generate new thread names
-_counter = 0
+_counter = _count().next
+_counter() # Consume 0 so first non-main thread has id 1.
 def _newname(template="Thread-%d"):
-    global _counter
-    _counter = _counter + 1
-    return template % _counter
+    return template % _counter()
 
 # Active thread administration
 _active_limbo_lock = _allocate_lock()