summaryrefslogtreecommitdiff
path: root/Lib/posixpath.py
diff options
context:
space:
mode:
authorHynek Schlawack <hs@ox.cx>2012-07-17 13:10:15 +0200
committerHynek Schlawack <hs@ox.cx>2012-07-17 13:10:15 +0200
commit1815191f1722546f6af2b5207df4efaa50be38fd (patch)
treef9b57d6c79d551df882f6982f9d18679c3d35f60 /Lib/posixpath.py
parent9c3cf6b4a00d9c77063378bd5a3a238f96a36542 (diff)
parentc5a45669229906a2ff8ea87bd69d1df2feac8ffc (diff)
downloadcpython-git-1815191f1722546f6af2b5207df4efaa50be38fd.tar.gz
#15377: Make posixpath.join() more strict when checking for str/bytes mix
Based on a patch by Nick Coghlan.
Diffstat (limited to 'Lib/posixpath.py')
-rw-r--r--Lib/posixpath.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/Lib/posixpath.py b/Lib/posixpath.py
index ab2aefface..39b16a87c7 100644
--- a/Lib/posixpath.py
+++ b/Lib/posixpath.py
@@ -83,12 +83,13 @@ def join(a, *p):
else:
path += sep + b
except TypeError:
- strs = [isinstance(s, str) for s in (a, ) + p]
- if any(strs) and not all(strs):
+ valid_types = all(isinstance(s, (str, bytes, bytearray))
+ for s in (a, ) + p)
+ if valid_types:
+ # Must have a mixture of text and binary data
raise TypeError("Can't mix strings and bytes in path "
"components.") from None
- else:
- raise
+ raise
return path