diff options
| author | Tal Einat <taleinat@gmail.com> | 2019-06-07 08:54:40 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-06-07 08:54:40 +0300 |
| commit | 554450fb4e95066e825bdb4a2d544a490daeebdc (patch) | |
| tree | dc68d632f8f78a161b53ad6d998b96da0fc99a1b /Lib/idlelib | |
| parent | de76c07a8cd0216c3dce215e4d542e2f45aa022f (diff) | |
| download | cpython-git-554450fb4e95066e825bdb4a2d544a490daeebdc.tar.gz | |
bpo-37177: make IDLE's search dialogs transient (GH-13869)
This avoids the search dialogs being hidden behind the editor window.
Diffstat (limited to 'Lib/idlelib')
| -rw-r--r-- | Lib/idlelib/idle_test/test_searchbase.py | 11 | ||||
| -rw-r--r-- | Lib/idlelib/searchbase.py | 2 |
2 files changed, 8 insertions, 5 deletions
diff --git a/Lib/idlelib/idle_test/test_searchbase.py b/Lib/idlelib/idle_test/test_searchbase.py index 6dd4d79337..e08268fde2 100644 --- a/Lib/idlelib/idle_test/test_searchbase.py +++ b/Lib/idlelib/idle_test/test_searchbase.py @@ -4,7 +4,7 @@ import unittest from test.support import requires -from tkinter import Tk +from tkinter import Text, Tk, Toplevel from tkinter.ttk import Frame from idlelib import searchengine as se from idlelib import searchbase as sdb @@ -47,14 +47,15 @@ class SearchDialogBaseTest(unittest.TestCase): # open calls create_widgets, which needs default_command self.dialog.default_command = None - # Since text parameter of .open is not used in base class, - # pass dummy 'text' instead of tk.Text(). - self.dialog.open('text') + toplevel = Toplevel(self.root) + self.addCleanup(toplevel.destroy) + text = Text(toplevel) + self.dialog.open(text) self.assertEqual(self.dialog.top.state(), 'normal') self.dialog.close() self.assertEqual(self.dialog.top.state(), 'withdrawn') - self.dialog.open('text', searchphrase="hello") + self.dialog.open(text, searchphrase="hello") self.assertEqual(self.dialog.ent.get(), 'hello') self.dialog.close() diff --git a/Lib/idlelib/searchbase.py b/Lib/idlelib/searchbase.py index 4ed94f186b..6fba0b8e58 100644 --- a/Lib/idlelib/searchbase.py +++ b/Lib/idlelib/searchbase.py @@ -54,6 +54,7 @@ class SearchDialogBase: else: self.top.deiconify() self.top.tkraise() + self.top.transient(text.winfo_toplevel()) if searchphrase: self.ent.delete(0,"end") self.ent.insert("end",searchphrase) @@ -66,6 +67,7 @@ class SearchDialogBase: "Put dialog away for later use." if self.top: self.top.grab_release() + self.top.transient('') self.top.withdraw() def create_widgets(self): |