summaryrefslogtreecommitdiff
path: root/Lib/distutils/command/config.py
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2018-12-20 19:00:14 +0200
committerGitHub <noreply@github.com>2018-12-20 19:00:14 +0200
commitc5d5dfdb223efb0e668e3f317d31b8b70ae96aa6 (patch)
tree75d656ef90a71f12cdf8b9cdbbaeaf3b4c341156 /Lib/distutils/command/config.py
parent71f82a2f2085464f5ec99c16bce57bd1631733bd (diff)
downloadcpython-git-c5d5dfdb223efb0e668e3f317d31b8b70ae96aa6.tar.gz
bpo-22831: Use "with" to avoid possible fd leaks in distutils. (GH-10921)
Diffstat (limited to 'Lib/distutils/command/config.py')
-rw-r--r--Lib/distutils/command/config.py36
1 files changed, 17 insertions, 19 deletions
diff --git a/Lib/distutils/command/config.py b/Lib/distutils/command/config.py
index 4ae153d194..f511b88857 100644
--- a/Lib/distutils/command/config.py
+++ b/Lib/distutils/command/config.py
@@ -106,15 +106,14 @@ class config(Command):
def _gen_temp_sourcefile(self, body, headers, lang):
filename = "_configtest" + LANG_EXT[lang]
- file = open(filename, "w")
- if headers:
- for header in headers:
- file.write("#include <%s>\n" % header)
- file.write("\n")
- file.write(body)
- if body[-1] != "\n":
- file.write("\n")
- file.close()
+ with open(filename, "w") as file:
+ if headers:
+ for header in headers:
+ file.write("#include <%s>\n" % header)
+ file.write("\n")
+ file.write(body)
+ if body[-1] != "\n":
+ file.write("\n")
return filename
def _preprocess(self, body, headers, include_dirs, lang):
@@ -203,17 +202,16 @@ class config(Command):
if isinstance(pattern, str):
pattern = re.compile(pattern)
- file = open(out)
- match = False
- while True:
- line = file.readline()
- if line == '':
- break
- if pattern.search(line):
- match = True
- break
+ with open(out) as file:
+ match = False
+ while True:
+ line = file.readline()
+ if line == '':
+ break
+ if pattern.search(line):
+ match = True
+ break
- file.close()
self._clean()
return match