summaryrefslogtreecommitdiff
path: root/Include/dictobject.h
diff options
context:
space:
mode:
authorNeal Norwitz <nnorwitz@gmail.com>2007-02-25 19:44:48 +0000
committerNeal Norwitz <nnorwitz@gmail.com>2007-02-25 19:44:48 +0000
commitee3a1b5244e60566c5d5c8f6a1ea4b381de99f1c (patch)
treead52a17fc77530870a575107a7cea9c27de17606 /Include/dictobject.h
parent5a3e812444609329b30be837a08c11269d917b72 (diff)
downloadcpython-git-ee3a1b5244e60566c5d5c8f6a1ea4b381de99f1c.tar.gz
Variation of patch # 1624059 to speed up checking if an object is a subclass
of some of the common builtin types. Use a bit in tp_flags for each common builtin type. Check the bit to determine if any instance is a subclass of these common types. The check avoids a function call and O(n) search of the base classes. The check is done in the various Py*_Check macros rather than calling PyType_IsSubtype(). All the bits are set in tp_flags when the type is declared in the Objects/*object.c files because PyType_Ready() is not called for all the types. Should PyType_Ready() be called for all types? If so and the change is made, the changes to the Objects/*object.c files can be reverted (remove setting the tp_flags). Objects/typeobject.c would also have to be modified to add conditions for Py*_CheckExact() in addition to each the PyType_IsSubtype check.
Diffstat (limited to 'Include/dictobject.h')
-rw-r--r--Include/dictobject.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/Include/dictobject.h b/Include/dictobject.h
index 44b0838e04..ec2e0c8214 100644
--- a/Include/dictobject.h
+++ b/Include/dictobject.h
@@ -90,7 +90,8 @@ struct _dictobject {
PyAPI_DATA(PyTypeObject) PyDict_Type;
-#define PyDict_Check(op) PyObject_TypeCheck(op, &PyDict_Type)
+#define PyDict_Check(op) \
+ PyType_FastSubclass((op)->ob_type, Py_TPFLAGS_DICT_SUBCLASS)
#define PyDict_CheckExact(op) ((op)->ob_type == &PyDict_Type)
PyAPI_FUNC(PyObject *) PyDict_New(void);