Remove asdl_seq_APPEND() and simplify asdl seq implementation.

Clarify intended use of set_context() and check errors at all call sites.

1 files changed, 2 insertions, 12 deletions

diff --git a/Include/asdl.h b/Include/asdl.h
index a2c86c8dd4..c1c5603e8b 100644
--- a/Include/asdl.h
+++ b/Include/asdl.h
@@ -15,33 +15,23 @@ typedef enum {false, true} bool;
 
 /* XXX A sequence should be typed so that its use can be typechecked. */
 
-/* XXX We shouldn't pay for offset when we don't need APPEND. */
-
 typedef struct {
     int size;
-    int offset;
     void *elements[1];
 } asdl_seq;
 
 asdl_seq *asdl_seq_new(int size, PyArena *arena);
-void asdl_seq_free(asdl_seq *);
 
-#ifdef Py_DEBUG
 #define asdl_seq_GET(S, I) (S)->elements[(I)]
+#define asdl_seq_LEN(S) ((S) == NULL ? 0 : (S)->size)
+#ifdef Py_DEBUG
 #define asdl_seq_SET(S, I, V) { \
         int _asdl_i = (I); \
         assert((S) && _asdl_i < (S)->size); \
         (S)->elements[_asdl_i] = (V); \
 }
-#define asdl_seq_APPEND(S, V) { \
-        assert((S) && (S)->offset < (S)->size); \
-        (S)->elements[(S)->offset++] = (V); \
-}
 #else
-#define asdl_seq_GET(S, I) (S)->elements[(I)]
 #define asdl_seq_SET(S, I, V) (S)->elements[I] = (V)
-#define asdl_seq_APPEND(S, V) (S)->elements[(S)->offset++] = (V)
 #endif
-#define asdl_seq_LEN(S) ((S) == NULL ? 0 : (S)->size)
 
 #endif /* !Py_ASDL_H */