summaryrefslogtreecommitdiff
path: root/Doc
diff options
context:
space:
mode:
authorMickaƫl Schoentgen <contact@tiger-222.fr>2018-09-03 03:48:08 +0200
committerTerry Jan Reedy <tjreedy@udel.edu>2018-09-02 21:48:08 -0400
commit30af2e737aad427d4da97f8dadeeecff6c2b28f5 (patch)
treed2845d4c83d686f1116d0bb033aa1381a289ed5b /Doc
parent71f2dadf66c8f9f513bb67f3b06d320c406ac2ff (diff)
downloadcpython-git-30af2e737aad427d4da97f8dadeeecff6c2b28f5.tar.gz
bpo-34500: Fix ResourceWarning in difflib.py (GH-8926)
The change to Tools/scripts/diff.py effectively backports part of a2637729f23dc993e820fd92f0d1759ad714c9b2. The test code changed in Doc/library/difflib.rst is not present in current 3.x.
Diffstat (limited to 'Doc')
-rw-r--r--Doc/library/difflib.rst6
1 files changed, 4 insertions, 2 deletions
diff --git a/Doc/library/difflib.rst b/Doc/library/difflib.rst
index c6bf3ef677..01a3bfc2cd 100644
--- a/Doc/library/difflib.rst
+++ b/Doc/library/difflib.rst
@@ -757,8 +757,10 @@ It is also contained in the Python source distribution, as
# we're passing these as arguments to the diff function
fromdate = time.ctime(os.stat(fromfile).st_mtime)
todate = time.ctime(os.stat(tofile).st_mtime)
- fromlines = open(fromfile, 'U').readlines()
- tolines = open(tofile, 'U').readlines()
+ with open(fromfile, 'U') as f:
+ fromlines = f.readlines()
+ with open(tofile, 'U') as f:
+ tolines = f.readlines()
if options.u:
diff = difflib.unified_diff(fromlines, tolines, fromfile, tofile,