summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-08-20 21:12:18 -0700
committerGitHub <noreply@github.com>2019-08-20 21:12:18 -0700
commit198a0d622a696a4c234aa7866d6c15e38839cc76 (patch)
tree68639f5e7d8082ac16c0f5de8616729d17c0b48b
parent35f9bccd8198330579ecb4b4c503062f8b5da130 (diff)
downloadcpython-git-198a0d622a696a4c234aa7866d6c15e38839cc76.tar.gz
bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
If this service had thoroughly vanished, we could just ignore the test until someone gets around to either recreating such a service or redesigning the test to somehow work locally. The `support.transient_internet` mechanism catches the failure to resolve the domain name, and skips the test. But in fact the domain snakebite.net does still exist, as do its nameservers -- and they can be quite slow to reply. As a result this test can easily take 20-30s before it gets auto-skipped. So, skip the test explicitly up front. (cherry picked from commit 5b95a1507e349da5adae6d2ab57deac3bdd12f15) Co-authored-by: Greg Price <gnprice@gmail.com>
-rw-r--r--Lib/test/test_timeout.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/Lib/test/test_timeout.py b/Lib/test/test_timeout.py
index bb9252d1a4..51690335b7 100644
--- a/Lib/test/test_timeout.py
+++ b/Lib/test/test_timeout.py
@@ -106,6 +106,7 @@ class TimeoutTestCase(unittest.TestCase):
def tearDown(self):
self.sock.close()
+ @unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
def testConnectTimeout(self):
# Choose a private address that is unlikely to exist to prevent
# failures due to the connect succeeding before the timeout.